Code

Opened 8 months ago

Closed 8 months ago

Last modified 8 months ago

#20905 closed Bug (fixed)

Test failure on Oracle: test_child_link_prefetch

Reported by: shai Owned by: nobody
Component: Database layer (models, ORM) Version: 1.4
Severity: Normal Keywords: oracle
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Running tests on update stable/1.4.x

FAIL: test_child_link_prefetch (modeltests.prefetch_related.tests.MultiTableInheritanceTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/django/django/django/test/utils.py", line 215, in inner
    return test_func(*args, **kwargs)
  File "/home/django/django/tests/modeltests/prefetch_related/tests.py", line 367, in test_child_link_prefetch
    self.assertIn('authorwithage', connection.queries[-1]['sql'])
AssertionError: 'authorwithage' not found in 'SELECT "PREFETCH_RELATED_AUTHOR"."ID", "PREFETCH_RELATED_AUTHOR"."NAME", "PREFETCH_RELATED_AUTHOR"."FIRST_BOOK_ID", "PREFETCH_RELATED_AUTHORWITHAGE"."AUTHOR_ID", "PREFETCH_RELATED_AUTHORWITHAGE"."AGE" FROM "PREFETCH_RELATED_AUTHORWITHAGE" INNER JOIN "PREFETCH_RELATED_AUTHOR" ON ("PREFETCH_RELATED_AUTHORWITHAGE"."AUTHOR_ID" = "PREFETCH_RELATED_AUTHOR"."ID") WHERE "PREFETCH_RELATED_AUTHORWITHAGE"."AUTHOR_ID" IN (:arg0, :arg1, :arg2) ORDER BY "PREFETCH_RELATED_AUTHORWITHAGE"."AUTHOR_ID" ASC'

Test fails because of Oracle's letter-case issues.

Attachments (0)

Change History (2)

comment:1 Changed 8 months ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from new to closed

In bf611f14ec13312aa822beec72c63bd04950613c:

[1.4.x] Fixed #20905 -- Fixed an Oracle-specific test case failure

Made a test checking ORM-generated query string case-insensitive.

Backport of ee0a7c741e from master

comment:2 Changed 8 months ago by shai

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Thanks, Tim!

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.