`ModelBackend.authenticate` raises an assertion error when no password is specified.
|Reported by:||charettes||Owned by:||charettes|
|Cc:||Triage Stage:||Ready for checkin|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
Prior to this change authenticate returned None when no password was specified.
Note that this affect version 1.6-beta-1 and master but I'm not sure this should be considered a release blocker.
I'm reporting because one of my testcases failed and I thought this change might have other side effects. We should at least raise a ValueError with a description instead of a non-intuitive assertion error.
I'll write tests and a fix if this gets accepted in order to backport it.
Change History (6)
comment:1 Changed 3 years ago by bmispelon
- Severity changed from Normal to Release blocker
- Triage Stage changed from Unreviewed to Accepted
comment:5 Changed 3 years ago by Simon Charette <charette.s@…>
- Resolution set to fixed
- Status changed from assigned to closed