Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#19586 closed Bug (fixed)

URL_VALIDATOR_USER_AGENT is said to be deprecated, but has actually been removed

Reported by: m@… Owned by: nobody
Component: Documentation Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

The docs (https://docs.djangoproject.com/en/dev/ref/settings/#url-validator-user-agent) say that URL_VALIDATOR_USER_AGENT has been deprecated, but it's actually been removed.
There's at least two instances where that caused trouble; it was mentioned once (https://docs.djangoproject.com/en/dev/ref/settings/#url-validator-user-agent) on the django-users mailing list. I stumbled upon it trying to setup django-oscar (http://oscarcommerce.com/), a shop solution for Django. It fails trying to import the setting.

My preferred way of fixing it would be a DeprecationMessage, but I assume due to the looming release deadline, an update to the docs is more appropriate.

Change History (5)

comment:1 Changed 3 years ago by m@…

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

I just saw that URL_VALIDATOR_USER_AGENT was already deprecated in 1.3.1. https://docs.djangoproject.com/en/1.3/ref/settings/#url-validator-user-agent:

The string to use as the User-Agent header when checking to see if URLs exist (see the verify_exists option on URLField). This setting was deprecated in 1.3.1 along with verify_exists and will be removed in 1.4.

It still shows up in the docs for 1.4. https://docs.djangoproject.com/en/1.4/ref/settings/#url-validator-user-agent:

This setting was deprecated in 1.3.1 along with verify_exists and will be removed in 1.4.

So, really, it should just be removed from the docs of 1.5.

comment:2 Changed 3 years ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 066cf2d70e30d6fae2a53b71b44137afa44ae5fa:

Fixed #19586 - Removed URL_VALIDATOR_USER_AGENT from setting docs.

It was removed in Django 1.5, not deprecated.

comment:3 Changed 3 years ago by Tim Graham <timograham@…>

In 7f7b6a369b5d8749bf7ef3324803b8041ff59b56:

[1.5.x] Fixed #19586 - Removed URL_VALIDATOR_USER_AGENT from setting docs.

It was removed in Django 1.5, not deprecated.

Backport of 066cf2d70e from master

comment:4 Changed 3 years ago by anonymous

Just for completeness: The Feature was removed in 1.4 because it followed an accelerated deprecation process of only one major version instead of the usual two.

comment:5 Changed 3 years ago by Tim Graham <timograham@…>

In 7f7b6a369b5d8749bf7ef3324803b8041ff59b56:

[1.5.x] Fixed #19586 - Removed URL_VALIDATOR_USER_AGENT from setting docs.

It was removed in Django 1.5, not deprecated.

Backport of 066cf2d70e from master

Note: See TracTickets for help on using tickets.
Back to Top