Code

Opened 18 months ago

Closed 18 months ago

Last modified 17 months ago

#19585 closed Bug (fixed)

Unable to load cookie values as a dict

Reported by: claudep Owned by: nobody
Component: HTTP handling Version: master
Severity: Release blocker Keywords: regression
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Starting from the unicode_literals patch, we lost the possibility to load a cookie value by passing a dict to the load() method, as allowed by the Python docs (http://docs.python.org/2/library/cookie.html#Cookie.BaseCookie.load).
We shouldn't inconditionally transform the rawdata parameter in a string.

Attachments (1)

19585-1.diff (1.3 KB) - added by claudep 18 months ago.

Download all attachments as: .zip

Change History (5)

Changed 18 months ago by claudep

comment:1 Changed 18 months ago by apollo13

  • Triage Stage changed from Accepted to Ready for checkin

Looks good to me.

comment:2 Changed 18 months ago by Claude Paroz <claude@…>

  • Resolution set to fixed
  • Status changed from new to closed

In f08e739bc2ba5d3530a806378087227728369464:

Fixed #19585 -- Fixed loading cookie value as a dict

This regression was introduced by the 'unicode_literals' patch.

comment:3 Changed 18 months ago by Claude Paroz <claude@…>

In 1d03ff06bbcc726c815f26f79067692019b2c71a:

[1.5.x] Fixed #19585 -- Fixed loading cookie value as a dict

This regression was introduced by the 'unicode_literals' patch.
Backport of f08e739bc2 from master.

comment:4 Changed 17 months ago by Claude Paroz <claude@…>

In 1d03ff06bbcc726c815f26f79067692019b2c71a:

[1.5.x] Fixed #19585 -- Fixed loading cookie value as a dict

This regression was introduced by the 'unicode_literals' patch.
Backport of f08e739bc2 from master.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.