Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#19287 closed Bug (wontfix)

Change from "e-mail" to "email" not reflected in translation files for contrib.auth

Reported by: bmispelon Owned by: nobody
Component: contrib.auth Version: 1.5-alpha-1
Severity: Normal Keywords: e-mail i18n
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The changeset 2c8267bf3db608b99c04ae903c424b60cafaaf93 renamed all instances of "e-mail" to "email", both in the code and in the documentation.

It did not, however, touch the translation files in django/contrib/auth/locale/, causing missing translations.

As far as I can tell, this affects all locales except for "en".

I'm not sure what the release process for translations is, but this could probably be fixed with a simple sed incantation (every instance of "e-mail" is all lowercase).

Change History (3)

comment:1 Changed 2 years ago by claudep

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to wontfix
  • Status changed from new to closed

We could have done it at the same time as the change, but generally I don't like touching translation files behind the back of translators. Now it's too late for sure, as new translation files have been uploaded to Transifex and translators already began the translation process for 1.5. Note that the old translation is still available in Transifex as a suggestion, so those strings could be easily copied as the new translation.

https://www.transifex.com/projects/p/django/

comment:2 Changed 2 years ago by bmispelon

I see.

The translation strings are indeed correct on transifex (I was looking at the files on github).

I assume these translations will get pulled just before the release. Is this process documented somewhere (I looked but couldn't find any info)?

comment:3 Changed 2 years ago by claudep

Yes, we will pull the translations before the release (maybe before beta or rc also, if time permits).

See https://docs.djangoproject.com/en/dev/internals/contributing/localizing/ for the docs.

Note: See TracTickets for help on using tickets.
Back to Top