Opened 12 years ago
Last modified 10 years ago
#18603 new Cleanup/optimization
Adding support for PEP 302 importers
Reported by: | bhuztez | Owned by: | nobody |
---|---|---|---|
Component: | Core (Other) | Version: | |
Severity: | Normal | Keywords: | |
Cc: | cberner | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | yes |
Easy pickings: | no | UI/UX: | no |
Description
Django makes assumptions about the filesystem layout of python packages here and there, and will silently skip any app which does not meet Django's assumptions without raise up any warnings.
Adding support for PEP 302 importers can solve all these problems, including #582 #596 #8238 #8280 #12206 #13587 #16718 #17331. And I found that there are three different kinds of problems.
- find submodules before importing the package: finding management commands
- find submodules after importing the package: finding template tags(already solved by #13334) and listing available database backends
- find resource files after importing the package: template files, static files, fixtures and translation files
I have been working on solve these problems in the past few months, code is now available on Github: https://github.com/bhuztez/django/compare/master...pep-302
There are still a few problems.
- management command
- since we have to find management commands before importing any app packages, we still need to make assumptions, see https://code.djangoproject.com/ticket/14087#comment:13 . I think we have to make a better assumption on
loader.get_filename
. And how to find management commands in packages imported bysys.meta_path
?
- static files finder
- I changed static files finder API. now
Finder.find
returns[(storage, path)]
instead of[path]
.
- app package resource file regression tests
- templates, fixtures, translation files and static files (except collect_static) relies on same api to find resource files. Should I just add tests for the API, or I have to add almost same tests for templates, fixtures, translation files and static files?
- template loader
- I changed template loader API. I think the
template_dirs
parameter is confusing here inloader(template_name, template_dirs=None)
. if I set thetemplate_dirs
parameter,django.template.loaders.app_directories.Loader
works just likedjango.template.loaders.filesystem.Loader
, anddjango.template.loaders.eggs.Loader
does not respect my parameter.
- fixture path
- how to
humanize(fixture_storage)
?
Any ideas?
Change History (4)
comment:1 by , 12 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:2 by , 12 years ago
Cc: | added |
---|
comment:3 by , 12 years ago
Component: | Uncategorized → Core (Other) |
---|
comment:4 by , 10 years ago
Patch needs improvement: | set |
---|
Hey bhuztez,
I started work on part of this (the management command issue) because we've run into it. My patch is here. Let me know if I can be of assistance with other parts of this issue.