Code

Opened 4 years ago

Closed 4 years ago

Last modified 2 years ago

#13587 closed Uncategorized (invalid)

Set zip_safe = False in setup.py

Reported by: timo Owned by: nobody
Component: Core (Other) Version: master
Severity: Normal Keywords: setup.py
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Django isn't zip_safe:

django.contrib.gis.tests.geogapp.tests: module references __file__
django.contrib.gis.tests.geo3d.tests: module references __file__
django.contrib.gis.tests.layermap.tests: module references __file__
django.contrib.gis.gdal.tests.test_ds: module references __file__
django.contrib.admindocs.views: module references __file__
django.contrib.auth.tests.views: module references __file__
django.utils.autoreload: module references __file__
django.utils.module_loading: module references __path__
django.utils.version: module references __path__
django.utils.translation.trans_real: module references __file__
django.test._doctest: module references __file__
django.test._doctest: module MAY be using inspect.getsourcefile
django.test.simple: module references __file__
django.core.management.sql: module references __file__
django.core.management.base: module references __path__
django.core.management.__init__: module references __file__
django.core.management.__init__: module references __path__
django.core.management.commands.loaddata: module references __file__
django.core.management.commands.loaddata: module references __path__
django.core.management.commands.makemessages: module references __file__
django.core.servers.basehttp: module references __path__
django.views.i18n: module references __file__
django.db.utils: module references __file__
django.db.models.loading: module references __file__
django.conf.__init__: module references __file__
django.conf.project_template.manage: module references __file__
django.template.loaders.app_directories: module references __file__

Any reason not to set the zip_safe flag in setup.py? This was addressed in #538 but the flag was lost at some point when setup.py was refactored.

Attachments (1)

zip_safe.diff (385 bytes) - added by timo 4 years ago.

Download all attachments as: .zip

Change History (3)

Changed 4 years ago by timo

comment:1 Changed 4 years ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to invalid
  • Status changed from new to closed

Yes, there is a reason - Django uses distutils, not setuptools. zip_safe is a setuptools option; if you apply the provided patch and run python setup.py install , you get the warning {{{UserWarning: Unknown distribution option: 'zip_safe'
}}}

comment:2 Changed 2 years ago by bhuztez

  • Easy pickings unset
  • Severity set to Normal
  • Type set to Uncategorized
  • UI/UX unset

the zip_egg_fixed patch for #14087 can fix this.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.