Code

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#13588 closed (fixed)

removing admin.root as per deprecation policy

Reported by: apollo13 Owned by: nobody
Component: contrib.admin Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description

I started working on the admin deprecation stuff. There is one remaining #TODO where I don't know how to fix it. This only covers the python files. The templates would require a custom tag or something similar, cause I can't create the reverse name in the templates dynamically. I didn't find a nice solution to work around that, so I'll leave it for now.

Attachments (5)

newstyle_admin.diff (14.2 KB) - added by apollo13 4 years ago.
admin_urlresolvers.diff (23.8 KB) - added by apollo13 4 years ago.
admin_urlresolvers2.diff (24.2 KB) - added by apollo13 4 years ago.
admin_urlresolvers3.diff (25.5 KB) - added by apollo13 4 years ago.
13588-admin-templates.diff (10.8 KB) - added by ramiro 4 years ago.
Patch with modifications to admin templates, as per Florian request on IRC

Download all attachments as: .zip

Change History (14)

Changed 4 years ago by apollo13

comment:1 Changed 4 years ago by apollo13

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

I found some bugs with this patch, will upload a new version tomorrow

comment:2 Changed 4 years ago by apollo13

Ok, I updated the patch now. I can't see why this patch would need tests as all of the behaviour is tested already (just relative vs absolute paths now, which is fixed in the tests).

Changed 4 years ago by apollo13

Changed 4 years ago by apollo13

comment:3 Changed 4 years ago by apollo13

fixed to missing current_app hints

comment:4 Changed 4 years ago by apollo13

remove call from ModelAdmin too

Changed 4 years ago by apollo13

comment:5 Changed 4 years ago by russellm

  • Triage Stage changed from Unreviewed to Accepted

This needs to wait until the 1.3 feature branch is forked.

Changed 4 years ago by ramiro

Patch with modifications to admin templates, as per Florian request on IRC

comment:6 Changed 3 years ago by ramiro

Removal of Python code was done in r14138 and 14412.

comment:7 Changed 3 years ago by ramiro

  • Patch needs improvement set

More commits where leftovers of code related to this were removed: r14209 and r14672.

comment:8 Changed 3 years ago by ramiro

  • Resolution set to fixed
  • Status changed from new to closed

The four commits referenced (r14138, r14209, r14412, r14672) have implemented together a great part of that was proposed by apollo13's patch and they dealt with the original intent of this ticket: Removing usage of .root to comply with our feature deprecation schedule. So we can close this ticket as fixed.

Remaining parts deal with removing and fixing bugs with usage of ../../../-style relative links in Python code, raw ID widgets and template code all inside the admin app. We possibly will open separate ticket(s) for these if there aren't any yet.

comment:9 Changed 3 years ago by jacob

  • milestone 1.3 deleted

Milestone 1.3 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.