#13588 closed (fixed)
removing admin.root as per deprecation policy
| Reported by: | Florian Apolloner | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
I started working on the admin deprecation stuff. There is one remaining #TODO where I don't know how to fix it. This only covers the python files. The templates would require a custom tag or something similar, cause I can't create the reverse name in the templates dynamically. I didn't find a nice solution to work around that, so I'll leave it for now.
Attachments (5)
Change History (14)
by , 14 years ago
| Attachment: | newstyle_admin.diff added |
|---|
comment:1 by , 14 years ago
comment:2 by , 14 years ago
Ok, I updated the patch now. I can't see why this patch would need tests as all of the behaviour is tested already (just relative vs absolute paths now, which is fixed in the tests).
by , 14 years ago
| Attachment: | admin_urlresolvers.diff added |
|---|
by , 14 years ago
| Attachment: | admin_urlresolvers2.diff added |
|---|
by , 14 years ago
| Attachment: | admin_urlresolvers3.diff added |
|---|
comment:5 by , 14 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
This needs to wait until the 1.3 feature branch is forked.
by , 14 years ago
| Attachment: | 13588-admin-templates.diff added |
|---|
Patch with modifications to admin templates, as per Florian request on IRC
comment:7 by , 14 years ago
| Patch needs improvement: | set |
|---|
comment:8 by , 14 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
The four commits referenced (r14138, r14209, r14412, r14672) have implemented together a great part of that was proposed by apollo13's patch and they dealt with the original intent of this ticket: Removing usage of .root to comply with our feature deprecation schedule. So we can close this ticket as fixed.
Remaining parts deal with removing and fixing bugs with usage of ../../../-style relative links in Python code, raw ID widgets and template code all inside the admin app. We possibly will open separate ticket(s) for these if there aren't any yet.
I found some bugs with this patch, will upload a new version tomorrow