Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#13588 closed (fixed)

removing admin.root as per deprecation policy

Reported by: Florian Apolloner Owned by: nobody
Component: contrib.admin Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description

I started working on the admin deprecation stuff. There is one remaining #TODO where I don't know how to fix it. This only covers the python files. The templates would require a custom tag or something similar, cause I can't create the reverse name in the templates dynamically. I didn't find a nice solution to work around that, so I'll leave it for now.

Attachments (5)

newstyle_admin.diff (14.2 KB) - added by Florian Apolloner 6 years ago.
admin_urlresolvers.diff (23.8 KB) - added by Florian Apolloner 6 years ago.
admin_urlresolvers2.diff (24.2 KB) - added by Florian Apolloner 6 years ago.
admin_urlresolvers3.diff (25.5 KB) - added by Florian Apolloner 6 years ago.
13588-admin-templates.diff (10.8 KB) - added by Ramiro Morales 6 years ago.
Patch with modifications to admin templates, as per Florian request on IRC

Download all attachments as: .zip

Change History (14)

Changed 6 years ago by Florian Apolloner

Attachment: newstyle_admin.diff added

comment:1 Changed 6 years ago by Florian Apolloner

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

I found some bugs with this patch, will upload a new version tomorrow

comment:2 Changed 6 years ago by Florian Apolloner

Ok, I updated the patch now. I can't see why this patch would need tests as all of the behaviour is tested already (just relative vs absolute paths now, which is fixed in the tests).

Changed 6 years ago by Florian Apolloner

Attachment: admin_urlresolvers.diff added

Changed 6 years ago by Florian Apolloner

Attachment: admin_urlresolvers2.diff added

comment:3 Changed 6 years ago by Florian Apolloner

fixed to missing current_app hints

comment:4 Changed 6 years ago by Florian Apolloner

remove call from ModelAdmin too

Changed 6 years ago by Florian Apolloner

Attachment: admin_urlresolvers3.diff added

comment:5 Changed 6 years ago by Russell Keith-Magee

Triage Stage: UnreviewedAccepted

This needs to wait until the 1.3 feature branch is forked.

Changed 6 years ago by Ramiro Morales

Attachment: 13588-admin-templates.diff added

Patch with modifications to admin templates, as per Florian request on IRC

comment:6 Changed 6 years ago by Ramiro Morales

Removal of Python code was done in r14138 and 14412.

comment:7 Changed 6 years ago by Ramiro Morales

Patch needs improvement: set

More commits where leftovers of code related to this were removed: r14209 and r14672.

comment:8 Changed 6 years ago by Ramiro Morales

Resolution: fixed
Status: newclosed

The four commits referenced (r14138, r14209, r14412, r14672) have implemented together a great part of that was proposed by apollo13's patch and they dealt with the original intent of this ticket: Removing usage of .root to comply with our feature deprecation schedule. So we can close this ticket as fixed.

Remaining parts deal with removing and fixing bugs with usage of ../../../-style relative links in Python code, raw ID widgets and template code all inside the admin app. We possibly will open separate ticket(s) for these if there aren't any yet.

comment:9 Changed 5 years ago by Jacob

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top