Opened 4 years ago

Closed 4 years ago

#16661 closed Cleanup/optimization (fixed)

Improvement of readability - false negation?

Reported by: greggmasterflash@… Owned by: nobody
Component: Documentation Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

It doesn't matter which model gets the ManyToManyField, but you only need it in one of the models -- not in both.
->
It doesn't matter which model gets the ManyToManyField, and you only need it in one of the models -- not in both.

Attachments (1)

16661.patch (787 bytes) - added by aaugustin 4 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 4 years ago by anonymous

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 4 years ago by aaugustin

  • Easy pickings set
  • Triage Stage changed from Unreviewed to Accepted

Yes, the wording here could be improved. Trivial patch attached.

Changed 4 years ago by aaugustin

comment:3 Changed 4 years ago by julien

  • Triage Stage changed from Accepted to Ready for checkin

comment:4 Changed 4 years ago by mtredinnick

The proposed change doesn't improve the clarity, since it's important the field is only put on one of the models. The suggested new text makes it sound like it might be okay to have it on both. I am committing a small variation that makes this clear (strengthening the negative, in fact).

comment:5 Changed 4 years ago by mtredinnick

Fixed in r16639.

comment:6 Changed 4 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.
Back to Top