Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#16662 closed Bug (invalid)

Comments does not set is_public to false for comments under moderation

Reported by: oyvind.saltvik@… Owned by: nobody
Component: contrib.comments Version: 1.3
Severity: Release blocker Keywords: comments signals is_pubic gunicorn 1.2.5 pre_save
Cc: oyvind.saltvik@… Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Comment object not passed by reference in signals.comment_will_be_posted from post_coments view.

Setting is_public to false in Moderator.pre_save_moderation has no effect.

Proposed solution: make Moderator.pre_save_moderation return status code to set is_public or not.

Temporary solution: set is_public on the models pre_save to false

Details:

Django 1.2.5 on gunicorn

Change History (4)

comment:1 Changed 4 years ago by anonymous

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Summary changed from Commends does not set is_public to false for comments under moderation to Comments does not set is_public to false for comments under moderation

comment:2 Changed 4 years ago by oyvind.saltvik@…

  • Version changed from SVN to 1.3

Same on django 1.3 and gunicorn.

comment:3 Changed 4 years ago by oyvind.saltvik@…

  • Resolution set to invalid
  • Status changed from new to closed

Was a PEBKAC

comment:4 Changed 4 years ago by jacob

  • milestone 1.4 deleted

Milestone 1.4 deleted

Note: See TracTickets for help on using tickets.
Back to Top