Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#1659 closed defect (fixed)

[patch] [magic-removal] References to decomissioned "django.models" still exist

Reported by: Chris Beaven Owned by: Adrian Holovaty
Component: Core (Other) Version: magic-removal
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In the magic removal branch, the following files still have references to django.models which no longer exists:

django/contrib/auth/models.py
django/contrib/comments/views/karma.py
django/contrib/comments/views/userflags.py

Attachments (6)

karma.diff (1.4 KB) - added by James Bennett 10 years ago.
Patch for karma.py to (hopefully) bring it in line with latest m-r
karma.2.diff (1.5 KB) - added by James Bennett 10 years ago.
Missed a manager method
userflags.diff (3.6 KB) - added by James Bennett 10 years ago.
Updating userflags.py to m-r
userflags.2.diff (3.6 KB) - added by James Bennett 10 years ago.
Fix typo
userflags.3.diff (3.6 KB) - added by James Bennett 10 years ago.
Pesky manager methods
models.diff (1.2 KB) - added by James Bennett 10 years ago.
Fix auth models file for m-r (and remove some Ellington cruft)

Download all attachments as: .zip

Change History (17)

comment:1 Changed 10 years ago by Chris Beaven

Oh yea, also:

docs/authentication.txt
docs/forms.txt
docs/overview.txt
docs/request_response.txt
docs/syndication_feeds.txt

comment:2 Changed 10 years ago by James Bennett

I'm not seeing anything out of place in the auth models file. It imports django.db.models, not django.models. The other two still need refactoring, though. Since I'm doing some stuff that relies on the comments app, I'll try to get that tomorrow at work.

Changed 10 years ago by James Bennett

Attachment: karma.diff added

Patch for karma.py to (hopefully) bring it in line with latest m-r

Changed 10 years ago by James Bennett

Attachment: karma.2.diff added

Missed a manager method

Changed 10 years ago by James Bennett

Attachment: userflags.diff added

Updating userflags.py to m-r

Changed 10 years ago by James Bennett

Attachment: userflags.2.diff added

Fix typo

Changed 10 years ago by James Bennett

Attachment: userflags.3.diff added

Pesky manager methods

comment:3 Changed 10 years ago by James Bennett

Summary: [magic-removal] References to decomissioned "django.models" still exist[patch] [magic-removal] References to decomissioned "django.models" still exist

comment:4 Changed 10 years ago by Chris Beaven

Just made sure I had the latest version and yes to django.models still.

Line 215 of auth models file:

module = __import__('django.models.%s' % settings.AUTH_PROFILE_MODULE, [], [], [''])

Changed 10 years ago by James Bennett

Attachment: models.diff added

Fix auth models file for m-r (and remove some Ellington cruft)

comment:5 Changed 10 years ago by jkocherhans

The part of this dealing with comments was fixed in #1637.

comment:6 Changed 10 years ago by jkocherhans

django/contrib/auth/models.py fixed in [2723]. Thanks ubernostrum.

comment:7 Changed 10 years ago by Adrian Holovaty

Resolution: fixed
Status: newclosed

Is this fixed? Please reopen with specific stuff that still needs to be done, if there is any.

comment:8 Changed 10 years ago by anonymous

Resolution: fixed
Status: closedreopened
docs/forms.txt
docs/overview.txt
docs/request_response.txt
docs/syndication_feeds.txt

Still contain references to django.models. There aren't any references in the code anymore however. I'll reopen this for now, but maybe these should be part of another ticket.

comment:9 Changed 10 years ago by Adrian Holovaty

Resolution: fixed
Status: reopenedclosed

We're still working on those docs, so I'm closing the ticket.

comment:10 Changed 10 years ago by Home

Summary: [patch] [magic-removal] References to decomissioned "django.models" still exist[patch] [magic-removal] References to decomissioned "django.models" still exist

comment:11 Changed 10 years ago by Adrian Holovaty

milestone: Version 0.92

Milestone Version 0.92 deleted

Note: See TracTickets for help on using tickets.
Back to Top