Code

Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#1637 closed defect (fixed)

[patch] [magic-removal] django.contrib.comments still uses old methods

Reported by: Denis <kuzmichyov@…> Owned by: adrian
Component: Core (Other) Version: magic-removal
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

django.contrib.comments.models still uses old methods like get_user() and get_object(),
which are incompatible with M/R

Attachments (5)

models.py.diff (2.3 KB) - added by Denis <kuzmichyov@…> 8 years ago.
models.py.2.diff (2.8 KB) - added by Denis <kuzmichyov@…> 8 years ago.
Missed 1 line in the 1st variant
comments.diff (8.4 KB) - added by Dave St.Germain <dcs@…> 8 years ago.
patch for other comments files
comments.2.diff (11.2 KB) - added by Dave St.Germain <dcs@…> 8 years ago.
included Denis's patch
comments.3.diff (17.2 KB) - added by Dave St.Germain <dcs@…> 8 years ago.
includes other patches to comments

Download all attachments as: .zip

Change History (10)

Changed 8 years ago by Denis <kuzmichyov@…>

Changed 8 years ago by Denis <kuzmichyov@…>

Missed 1 line in the 1st variant

Changed 8 years ago by Dave St.Germain <dcs@…>

patch for other comments files

Changed 8 years ago by Dave St.Germain <dcs@…>

included Denis's patch

comment:1 Changed 8 years ago by Dave St.Germain <dcs@…>

  • Summary changed from django.contrib.comments.models still uses old methods to django.contrib.comments still uses old methods

Changed 8 years ago by Dave St.Germain <dcs@…>

includes other patches to comments

comment:2 Changed 8 years ago by Dave St.Germain <dcs@…>

  • milestone set to Version 0.92
  • Summary changed from django.contrib.comments still uses old methods to [patch] [magic-removal] django.contrib.comments still uses old methods

This ticket (and patch) includes #1659 and #1523. I hope this patch can be applied soon because the broken contrib.comments app is a blocker for me...

comment:3 Changed 8 years ago by ubernostrum

Actually, this patch doesn't quite cover #1659, since it's missing the fixes to the auth models file.

comment:4 Changed 8 years ago by jkocherhans

  • Resolution set to fixed
  • Status changed from new to closed

(In [2722]) magic-removal: fixed #1637 - django.contrib.comments still uses old methods. Thanks Dave St.Germain and ubernostrum.

comment:5 Changed 7 years ago by adrian

  • milestone Version 0.92 deleted

Milestone Version 0.92 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.