#16404 closed Cleanup/optimization (fixed)
intcomma & thousand separator
| Reported by: | Owned by: | Grepsd | |
|---|---|---|---|
| Component: | contrib.humanize | Version: | dev |
| Severity: | Release blocker | Keywords: | |
| Cc: | Grepsd | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | yes | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
The intcomma template filter from the humanize package isn't doing the thousand separating if you're not setting the USE_THOUSAND_SEPARATOR to True.
If you set the USE_THOUSAND_SEPARATOR, every number display in the template is processed, so the intcomma won't change that.
The intcomma should do the thousand separating without relying on the USE_THOUSAND_SEPARATOR setting.
NB : intcomma is calling number_format which is calling numberformat.format.
(from rev: 16168)
Attachments (1)
Change History (7)
comment:1 by , 14 years ago
| Triage Stage: | Unreviewed → Design decision needed |
|---|
by , 14 years ago
| Attachment: | diff_django_humanize_fix.diff added |
|---|
fix the humanize.intcomma template filter to force the use of grouping in the number_format.format method.
comment:2 by , 14 years ago
| Cc: | added |
|---|---|
| Has patch: | set |
| Owner: | changed from to |
| Version: | 1.3 → SVN |
comment:3 by , 14 years ago
| Component: | Template system → contrib.humanize |
|---|---|
| Needs tests: | set |
| Patch needs improvement: | set |
| Triage Stage: | Design decision needed → Accepted |
comment:4 by , 14 years ago
| Severity: | Normal → Release blocker |
|---|
Behavior is a regression from previous release, therefore release blocker.
Note:
See TracTickets
for help on using tickets.
I agree with you that is confusing.