Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#16403 closed Bug (fixed)

contrib.comments uses wrong pluralization of profanity message

Reported by: Dan Poirier Owned by: nobody
Component: contrib.comments Version: 1.3
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

contrib.comments says "Watch your mouth! The word %s is not allowed here." for multiple profanities and "Watch your mouth! The words %s are not allowed here." for single ones.

This is because ungettext is being used incorrectly (just like case #5011 from four years ago) - the third arg should be the number of items, not a boolean.

Patch attached.

Attachments (2)

django-comments-ungettext.diff (904 bytes) - added by Dan Poirier 5 years ago.
django-comments-ungettext.2.diff (1.0 KB) - added by Ferry Jérémie <ferryjeremie@…> 5 years ago.

Download all attachments as: .zip

Change History (6)

Changed 5 years ago by Dan Poirier

comment:1 Changed 5 years ago by Jannis Leidel

Triage Stage: UnreviewedReady for checkin

comment:2 Changed 5 years ago by Jannis Leidel

Resolution: fixed
Status: newclosed

In [16505]:

Fixed #16403 -- Correctly use ungettext in comments form. Thanks, poirier.

Changed 5 years ago by Ferry Jérémie <ferryjeremie@…>

comment:3 Changed 5 years ago by Ferry Jérémie <ferryjeremie@…>

missind also i18n "and" string...

comment:4 Changed 5 years ago by Claude Paroz

Latest comment added as new ticket #17597.

Note: See TracTickets for help on using tickets.
Back to Top