Opened 17 years ago

Closed 17 years ago

#5011 closed (fixed)

validators hasNoProfanities improperly uses ungettext

Reported by: tzellman@… Owned by: Adrian Holovaty
Component: Validators Version: dev
Severity: Keywords: ungettext validator
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

No matter how many words match the profanity list, it always returns the plural version of the error message. This is because ungettext expects a number rather than a boolean, which is what is currently being used.

Attached is 1-line diff that will fix this.

Attachments (1)

validators_patch.txt​ (679 bytes ) - added by tzellman@… 17 years ago.
1-line diff

Download all attachments as: .zip

Change History (3)

by tzellman@…, 17 years ago

Attachment: validators_patch.txt​ added

1-line diff

comment:1 by Simon G. <dev@…>, 17 years ago

Triage Stage: Unreviewed → Ready for checkin

comment:2 by Adrian Holovaty, 17 years ago

Resolution: → fixed
Status: new → closed

(In [5864]) Fixed #5011 -- Fixed usage of ungettext in hasNoProfanities validator. Thanks, tzellman@…

Note: See TracTickets for help on using tickets.
Back to Top