Opened 8 years ago

Closed 8 years ago

#5011 closed (fixed)

validators hasNoProfanities improperly uses ungettext

Reported by: tzellman@… Owned by: adrian
Component: Validators Version: master
Severity: Keywords: ungettext validator
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


No matter how many words match the profanity list, it always returns the plural version of the error message. This is because ungettext expects a number rather than a boolean, which is what is currently being used.

Attached is 1-line diff that will fix this.

Attachments (1)

validators_patch.txt (679 bytes) - added by tzellman@… 8 years ago.
1-line diff

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by tzellman@…

1-line diff

comment:1 Changed 8 years ago by Simon G. <dev@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 8 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [5864]) Fixed #5011 -- Fixed usage of ungettext in hasNoProfanities validator. Thanks, tzellman@…

Note: See TracTickets for help on using tickets.
Back to Top