Opened 5 years ago

Closed 4 years ago

Last modified 3 years ago

#15013 closed New feature (fixed)

Add Russian (ru) local flavour

Reported by: blackraven Owned by: blackraven
Component: contrib.localflavor Version: master
Severity: Normal Keywords: localflavor russian
Cc: kmike Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Should include fields for Russian passport numbers (for both internal and alien's passports), Russain postal code, Russian counties and regions select.

Attachments (3)

ru_localflavor_translation.diff (12.5 KB) - added by blackraven 5 years ago.
RU Translations for localflavor strings
ru_localflavor.diff (16.1 KB) - added by blackraven 4 years ago.
Improved Russian localflavor patch
15013.ru-localflavor.diff (16.8 KB) - added by julien 4 years ago.

Download all attachments as: .zip

Change History (16)

comment:1 Changed 5 years ago by blackraven

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to blackraven
  • Patch needs improvement unset
  • Status changed from new to assigned

comment:2 Changed 5 years ago by russellm

  • milestone 1.3 deleted
  • Needs tests set
  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Accepted

The deadline for new features in 1.3 has passed, so this can't be on the 1.3 milestone.

The translation fixes should be submitted as a separate patch, ideally after the string freeze (which shoud happen in a couple of weeks, when we release RC1).

The new localflavor code needs tests.

comment:3 Changed 5 years ago by blackraven

  • Needs tests unset
  • Patch needs improvement unset

comment:4 Changed 5 years ago by blackraven

Ticket #15027 raised for translation fixes

Changed 5 years ago by blackraven

RU Translations for localflavor strings

comment:5 Changed 5 years ago by anonymous

  • Cc kmike added

comment:6 Changed 5 years ago by kmike

Phone regexp is too restrictive.

It, for example, does not support cities with 4-digit codes. More examples of valid but obscure phone numbers and different regexps that are trying to solve the problem can be found here: http://habrahabr.ru/blogs/regex/110731/

I propose just to remove the phone validation - it is very hard to implement it properly and it doesn't provide much benefit, the simple min. length check is a proper solution in most cases.

comment:7 Changed 4 years ago by julien

  • Patch needs improvement set
  • Severity set to Normal
  • Type set to Uncategorized

Patch needs improvement as per kmike's comment above.

Changed 4 years ago by blackraven

Improved Russian localflavor patch

comment:8 Changed 4 years ago by blackraven

  • milestone set to 1.4
  • Patch needs improvement unset
  • Type changed from Uncategorized to New feature

comment:9 Changed 4 years ago by blackraven

Removed phone validation and phone field.

Changed 4 years ago by julien

comment:10 Changed 4 years ago by julien

  • Easy pickings unset
  • Triage Stage changed from Accepted to Ready for checkin

Thank you for your work. I have just added a missing import and did some minor edits in the doc.

comment:11 Changed 4 years ago by jezdez

  • Resolution set to fixed
  • Status changed from assigned to closed

In [16076]:

Fixed #15013 -- Added Russian (ru) localflavor package. Thanks, blackraven and Julien Phalip.

comment:12 Changed 4 years ago by jacob

  • milestone 1.4 deleted

Milestone 1.4 deleted

comment:13 Changed 3 years ago by Cjkjvfnby@…

  • UI/UX unset

It is strange field name: "alien passport".
Propably it is should be "foreign passport". (This is second passport of russian sitizen. It is used to cross borders and outside Russia)


Note: See TracTickets for help on using tickets.
Back to Top