Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#15013 closed New feature (fixed)

Add Russian (ru) local flavour

Reported by: Dmitry Pisklov Owned by: Dmitry Pisklov
Component: contrib.localflavor Version: master
Severity: Normal Keywords: localflavor russian
Cc: Mikhail Korobov Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Should include fields for Russian passport numbers (for both internal and alien's passports), Russain postal code, Russian counties and regions select.

Attachments (3)

ru_localflavor_translation.diff (12.5 KB) - added by Dmitry Pisklov 6 years ago.
RU Translations for localflavor strings
ru_localflavor.diff (16.1 KB) - added by Dmitry Pisklov 6 years ago.
Improved Russian localflavor patch
15013.ru-localflavor.diff (16.8 KB) - added by Julien Phalip 6 years ago.

Download all attachments as: .zip

Change History (16)

comment:1 Changed 6 years ago by Dmitry Pisklov

Owner: changed from nobody to Dmitry Pisklov
Status: newassigned

comment:2 Changed 6 years ago by Russell Keith-Magee

milestone: 1.3
Needs tests: set
Patch needs improvement: set
Triage Stage: UnreviewedAccepted

The deadline for new features in 1.3 has passed, so this can't be on the 1.3 milestone.

The translation fixes should be submitted as a separate patch, ideally after the string freeze (which shoud happen in a couple of weeks, when we release RC1).

The new localflavor code needs tests.

comment:3 Changed 6 years ago by Dmitry Pisklov

Needs tests: unset
Patch needs improvement: unset

comment:4 Changed 6 years ago by Dmitry Pisklov

Ticket #15027 raised for translation fixes

Changed 6 years ago by Dmitry Pisklov

RU Translations for localflavor strings

comment:5 Changed 6 years ago by anonymous

Cc: Mikhail Korobov added

comment:6 Changed 6 years ago by Mikhail Korobov

Phone regexp is too restrictive.

It, for example, does not support cities with 4-digit codes. More examples of valid but obscure phone numbers and different regexps that are trying to solve the problem can be found here: http://habrahabr.ru/blogs/regex/110731/

I propose just to remove the phone validation - it is very hard to implement it properly and it doesn't provide much benefit, the simple min. length check is a proper solution in most cases.

comment:7 Changed 6 years ago by Julien Phalip

Patch needs improvement: set
Severity: Normal
Type: Uncategorized

Patch needs improvement as per kmike's comment above.

Changed 6 years ago by Dmitry Pisklov

Attachment: ru_localflavor.diff added

Improved Russian localflavor patch

comment:8 Changed 6 years ago by Dmitry Pisklov

milestone: 1.4
Patch needs improvement: unset
Type: UncategorizedNew feature

comment:9 Changed 6 years ago by Dmitry Pisklov

Removed phone validation and phone field.

Changed 6 years ago by Julien Phalip

Attachment: 15013.ru-localflavor.diff added

comment:10 Changed 6 years ago by Julien Phalip

Easy pickings: unset
Triage Stage: AcceptedReady for checkin

Thank you for your work. I have just added a missing import and did some minor edits in the doc.

comment:11 Changed 6 years ago by Jannis Leidel

Resolution: fixed
Status: assignedclosed

In [16076]:

Fixed #15013 -- Added Russian (ru) localflavor package. Thanks, blackraven and Julien Phalip.

comment:12 Changed 5 years ago by Jacob

milestone: 1.4

Milestone 1.4 deleted

comment:13 Changed 5 years ago by Cjkjvfnby@…

UI/UX: unset

It is strange field name: "alien passport".
Propably it is should be "foreign passport". (This is second passport of russian sitizen. It is used to cross borders and outside Russia)


Note: See TracTickets for help on using tickets.
Back to Top