#15013 closed New feature (fixed)
Add Russian (ru) local flavour
| Reported by: | Dmitry Pisklov | Owned by: | Dmitry Pisklov |
|---|---|---|---|
| Component: | contrib.localflavor | Version: | dev |
| Severity: | Normal | Keywords: | localflavor russian |
| Cc: | Mikhail Korobov | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Should include fields for Russian passport numbers (for both internal and alien's passports), Russain postal code, Russian counties and regions select.
Attachments (3)
Change History (16)
comment:1 by , 14 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:2 by , 14 years ago
| milestone: | 1.3 |
|---|---|
| Needs tests: | set |
| Patch needs improvement: | set |
| Triage Stage: | Unreviewed → Accepted |
comment:3 by , 14 years ago
| Needs tests: | unset |
|---|---|
| Patch needs improvement: | unset |
by , 14 years ago
| Attachment: | ru_localflavor_translation.diff added |
|---|
RU Translations for localflavor strings
comment:5 by , 14 years ago
| Cc: | added |
|---|
comment:6 by , 14 years ago
Phone regexp is too restrictive.
It, for example, does not support cities with 4-digit codes. More examples of valid but obscure phone numbers and different regexps that are trying to solve the problem can be found here: http://habrahabr.ru/blogs/regex/110731/
I propose just to remove the phone validation - it is very hard to implement it properly and it doesn't provide much benefit, the simple min. length check is a proper solution in most cases.
comment:7 by , 14 years ago
| Patch needs improvement: | set |
|---|---|
| Severity: | → Normal |
| Type: | → Uncategorized |
Patch needs improvement as per kmike's comment above.
comment:8 by , 14 years ago
| milestone: | → 1.4 |
|---|---|
| Patch needs improvement: | unset |
| Type: | Uncategorized → New feature |
by , 14 years ago
| Attachment: | 15013.ru-localflavor.diff added |
|---|
comment:10 by , 14 years ago
| Easy pickings: | unset |
|---|---|
| Triage Stage: | Accepted → Ready for checkin |
Thank you for your work. I have just added a missing import and did some minor edits in the doc.
comment:13 by , 13 years ago
| UI/UX: | unset |
|---|
It is strange field name: "alien passport".
Propably it is should be "foreign passport". (This is second passport of russian sitizen. It is used to cross borders and outside Russia)
The deadline for new features in 1.3 has passed, so this can't be on the 1.3 milestone.
The translation fixes should be submitted as a separate patch, ideally after the string freeze (which shoud happen in a couple of weeks, when we release RC1).
The new localflavor code needs tests.