Code

Opened 4 years ago

Closed 4 years ago

#14851 closed (fixed)

rev14844 breaks Django completely

Reported by: mk Owned by: nobody
Component: Core (Other) Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation:
Needs tests: Patch needs improvement:
Easy pickings: UI/UX:

Description

After applying this patch it works again (Python 2.5).

diff --git a/django/utils/log.py b/django/utils/log.py
index d3c8e67..75422c7 100644
--- a/django/utils/log.py
+++ b/django/utils/log.py
@@ -87,7 +87,7 @@ class AdminEmailHandler(logging.Handler):
             stack_trace = 'No stack trace available'
 
         message = "%s\n\n%s" % (stack_trace, request_repr)
-        reporter = ExceptionReporter(request, *exc_info, is_email=True)
+        reporter = ExceptionReporter(request, is_email=True, *exc_info)
         html_message = reporter.get_traceback_html()
         mail.mail_admins(subject, message, fail_silently=True,
                          html_message=html_message)

Attachments (0)

Change History (1)

comment:1 Changed 4 years ago by jezdez

  • Resolution set to fixed
  • Status changed from new to closed

(In [14845]) Fixed #14851 -- Swapped an argument order to fix compatibility with Python<2.6. Thanks for report and patch, mk.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.