Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#14842 closed (fixed)

Indent the Model Meta Options

Reported by: Adam Vandenberg Owned by: nobody
Component: Documentation Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description

Per r14830, fix the indentation on the Model Meta Options docs.

Attachments (4)

indent-options.diff (13.5 KB) - added by Adam Vandenberg 6 years ago.
indent-options2.diff (16.7 KB) - added by Adam Vandenberg 6 years ago.
Rebased on master, takes into account new ordering docs.
indent-options3.diff (16.0 KB) - added by Adam Vandenberg 6 years ago.
Trying again.
indent-options4.diff (15.1 KB) - added by Adam Vandenberg 6 years ago.
One more try

Download all attachments as: .zip

Change History (12)

Changed 6 years ago by Adam Vandenberg

Attachment: indent-options.diff added

comment:1 Changed 6 years ago by Greg Turner

Resolution: duplicate
Status: newclosed

I think this is a duplicate of #14835, which is fixed.

comment:2 Changed 6 years ago by Adam Vandenberg

Resolution: duplicate
Status: closedreopened

The referenced ticket was for a page in the contrib admin docs. This is for a the Model meta options. So, not a duplicate.

comment:3 Changed 6 years ago by Gabriel Hurley

Triage Stage: UnreviewedAccepted

comment:4 Changed 6 years ago by Adam Vandenberg

Let me double-check the diff I posted before any committer takes this; will post an update if needed tonight.

Changed 6 years ago by Adam Vandenberg

Attachment: indent-options2.diff added

Rebased on master, takes into account new ordering docs.

Changed 6 years ago by Adam Vandenberg

Attachment: indent-options3.diff added

Trying again.

comment:5 Changed 6 years ago by Tim Graham

Patch needs improvement: set

Hey Adam, unfortunately the patch no longer applies cleanly to trunk. If you can easily rebase, that would be great. Also, the section "Tables names" seems a bit out of place at the top of the page instead of within the Options.db_table section. Is the issue that the link won't resolve properly? If that's the case, I'd say maybe we could remove the table-names link and just use the link to Options.db_table instead. Thanks for all your work, Tim

comment:6 Changed 6 years ago by Adam Vandenberg

I'll rebase and re-edit this against trunk, maybe tonight. If not, then some time this week.

As far as the "table names" goes, I'll have to dig up my notes and see why I moved it.

Changed 6 years ago by Adam Vandenberg

Attachment: indent-options4.diff added

One more try

comment:7 Changed 6 years ago by Tim Graham

Resolution: fixed
Status: reopenedclosed

(In [15110]) Fixed #14842 - Indent the model Meta options. Thanks adamv.

comment:8 Changed 6 years ago by Tim Graham

(In [15111]) [1.2.X] Fixed #14842 - Indent the model Meta options. Thanks adamv.

Backport of r15110 from trunk.

Note: See TracTickets for help on using tickets.
Back to Top