Test failure with get_image_dimensions since 
|Reported by:||Gabriel Hurley||Owned by:||Gabriel Hurley|
|Severity:||Keywords:||get_image_dimensions PIL mode|
|Cc:||Triage Stage:||Ready for checkin|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
On my windows xp machine (not on my mac os x box) the file_storage.InconsistentGetImageDimensionsBug fails because PIL is unable to read the data from the already-open ImageFile. The problem is that in the test case the ImageFile is created by calling open() on the file path without an explicit mode. This defaults to mode 'r', and PIL on Windows seems to only parse the data from the ImageFile if the mode is 'rb'.
I've attached a tiny patch that adds the mode flag to the test case, but when dealing with images the mode flag really ought to always be 'rb', right? Maybe there ought to be a larger fix here...
Change History (5)
comment:1 Changed 6 years ago by
|Owner:||changed from nobody to Gabriel Hurley|
|Patch needs improvement:||unset|
|Status:||new → assigned|