Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#14279 closed (fixed)

typo in tests for private flatpage not showing sitemaps

Reported by: James O'Donnell Owned by: nobody
Component: Contrib apps Version: master
Severity: Keywords: flatpages sitemaps
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In django/trunk/django/contrib/sitemaps/tests/basic.py, both the public and private Flatpage objects have their title set to "Public Page"

The attached patch changes the title of the public Flatpage to "Private Page"

Attachments (1)

private_flatpage_test.diff (530 bytes) - added by James O'Donnell 6 years ago.

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by James O'Donnell

Attachment: private_flatpage_test.diff added

comment:1 Changed 6 years ago by Gabriel Hurley

milestone: 1.3
Triage Stage: UnreviewedReady for checkin

This typo didn't actually affect the test, but it's good to correct the typo.

Patch applies cleanly, passes tests, issue is valid, marking RFC.

comment:2 Changed 6 years ago by Alex Gaynor

Resolution: fixed
Status: newclosed

(In [14136]) Fixed #14279 -- Corrected a typo in the sitemaps tests (didn't affect the passage of the test). Thanks to jamesodo for the report and patch.

comment:3 Changed 6 years ago by Alex Gaynor

(In [14137]) [1.2.X] Fixed #14279 -- Corrected a typo in the sitemaps tests (didn't affect the passage of the test). Thanks to jamesodo for the report and patch. Backport of [14136].

comment:4 Changed 5 years ago by Jacob

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top