Code

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#14279 closed (fixed)

typo in tests for private flatpage not showing sitemaps

Reported by: jamesodo Owned by: nobody
Component: Contrib apps Version: master
Severity: Keywords: flatpages sitemaps
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In django/trunk/django/contrib/sitemaps/tests/basic.py, both the public and private Flatpage objects have their title set to "Public Page"

The attached patch changes the title of the public Flatpage to "Private Page"

Attachments (1)

private_flatpage_test.diff (530 bytes) - added by jamesodo 4 years ago.

Download all attachments as: .zip

Change History (5)

Changed 4 years ago by jamesodo

comment:1 Changed 4 years ago by gabrielhurley

  • milestone set to 1.3
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

This typo didn't actually affect the test, but it's good to correct the typo.

Patch applies cleanly, passes tests, issue is valid, marking RFC.

comment:2 Changed 4 years ago by Alex

  • Resolution set to fixed
  • Status changed from new to closed

(In [14136]) Fixed #14279 -- Corrected a typo in the sitemaps tests (didn't affect the passage of the test). Thanks to jamesodo for the report and patch.

comment:3 Changed 4 years ago by Alex

(In [14137]) [1.2.X] Fixed #14279 -- Corrected a typo in the sitemaps tests (didn't affect the passage of the test). Thanks to jamesodo for the report and patch. Backport of [14136].

comment:4 Changed 3 years ago by jacob

  • milestone 1.3 deleted

Milestone 1.3 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.