Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#14280 closed (fixed)

Duplicate deepcopy import in django/db/models/query.py

Reported by: Carl Meyer Owned by: nobody
Component: Database layer (models, ORM) Version: master
Severity: Keywords: sprintSep2010
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In django/db/models/query.py, deepcopy is imported once from copy, and later from django.utils.copycompat. The duplicate was introduced by the multi-db merge (r11952), after the switch had been made to django.utils.copycompat only a few days earlier (r11901).

The copy.deepcopy import is higher in the file, so has no effect, but removing it could help avoid confusion in future.

Attachments (1)

14280_r13817.diff (390 bytes) - added by Carl Meyer 6 years ago.

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by Carl Meyer

Attachment: 14280_r13817.diff added

comment:1 Changed 6 years ago by Alex Gaynor

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedReady for checkin

comment:2 Changed 6 years ago by Jannis Leidel

Resolution: fixed
Status: newclosed

(In [13877]) Fixed #14280 -- Fixed duplicate import of deepcopy. Thanks, Carl Meyer.

comment:3 Changed 6 years ago by Jannis Leidel

(In [13878]) [1.2.X] Fixed #14280 -- Fixed duplicate import of deepcopy. Thanks, Carl Meyer.

Backport from trunk (r13877).

Note: See TracTickets for help on using tickets.
Back to Top