Change language to dynamic attribute in syndication feed generator

[jedie]

In my project, the language is dynamic and not hardcoded in settings. IMHO there is no way to change the language in syndication feed generator without a hack.

Change language to dynamic attribute in syndication feed generator:

django/contrib/syndication/views.py

@@ -104 +104 @@
             subtitle = self.__get_dynamic_attr('subtitle', obj),
             link = link,
             description = self.__get_dynamic_attr('description', obj),
-            language = settings.LANGUAGE_CODE.decode(),
+            language=self.__get_dynamic_attr('language', obj, settings.LANGUAGE_CODE.decode()),
             feed_url = add_domain(current_site.domain,
                     self.__get_dynamic_attr('feed_url', obj) or request.path),
             author_name = self.__get_dynamic_attr('author_name', obj),

[Matthias Kestenholz]

I think this makes sense. The language of the feed might be encoded inside the URL too and isn't fixed to LANGUAGE_CODE from the site settings.

This change has to be documented.

[Jason Kotenko]

Adding SVN diff that includes the patch included above and a patch for the docs, mentioning that now the language attribute can be set, and otherwise defaults to the project-wide setting for LANGUAGE_CODE.

[Jason Kotenko]

SVN Diff

[Jason Kotenko]

SVN Diff

[Jason Kotenko]

New diff entered, includes Fix, Docs, and Regression Test. Use the second patch, as the first is wrong. Thanks.

[Chris Morgan]

It would be very nice if this could get put into Django 1.3. I've had to hack this into shape myself to get it working for the new Inkscape website which can make news feeds for any supported language, using request.LANGUAGE_CODE rather than settings.LANGUAGE_CODE (seems to me that that is going to be a common request; I think it would be good if Feed stored the Request - but that's another ticket).

See ​http://bazaar.launchpad.net/~inkscape-webadmin/inkscape-web/inkscape-web/revision/62 for how I ended up wedging it in (1.2.5): and I know it won't work even back in 1.2.3 due to a couple of changes in the Django code, without providing another couple of methods. Not very maintainable :-(

[patchhammer]

django_13896_2.diff fails to apply cleanly on to trunk

[Jason Kotenko]

Latest SVN Diff

[Jason Kotenko]

Looks like bitrot got the best of the last one. New diff uploaded, new test passes under "settings=test_sqlite".

[Julien Phalip]

The patch looks pretty good but there is one slight inconsistency. The doc says:

You  can set the language for a feed by specifying an attribute :attr:`language`,  using the ***same format*** as the project-wide setting :setting:`LANGUAGE_CODE`.

... yet the code is:

language = self.__get_dynamic_attr('language', obj, settings.LANGUAGE_CODE.decode()),

So the LANGUAGE_CODE setting is decoded whereas the language API attribute isn't. Ideally the behaviour should be normalised and made consistent.

[Aymeric Augustin]

#7039 was closed as a duplicate.

[Mariusz Felisiak]

Closing as a duplicate of fixed #29352.