Opened 9 years ago

Closed 5 years ago

#7039 closed New feature (duplicate)

Feed 'language' is fixed to LANGUAGE_CODE - cann't work correct in multi-language site

Reported by: oleksandr Owned by: nobody
Component: contrib.syndication Version: master
Severity: Normal Keywords: feed rss language
Cc: write@… Triage Stage: Accepted
Has patch: yes Needs documentation: yes
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

Feed 'language' is fixed to LANGUAGE_CODE - cannot work correct in multi-language site.

Should be asked as Feed class attribute first, to be able to define language in different site faces:

   language = self.__get_dynamic_attr('language', obj) or settings.LANGUAGE_CODE.decode(),

Attachments (2)

patch_feedlang.diff (680 bytes) - added by write@… 9 years ago.
feed language patch
patch_feed_lang.diff (1.4 KB) - added by caa 8 years ago.
Fixed patch format and added documentation

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by write@…

Attachment: patch_feedlang.diff added

feed language patch

comment:1 Changed 9 years ago by Malcolm Tredinnick

Needs documentation: set
Patch needs improvement: set
Triage Stage: UnreviewedAccepted

Seems like a reasonable idea, but the patch needs improvement:

  1. The patch seems to be backwards, since it looks like you're trying to add the line that already exists.
  2. You are mixing tabs and spaces in the new code. Only spaces should be used for indentation.
  3. Also requires a change to the syndication documentation to explain the new feature.

Changed 8 years ago by caa

Attachment: patch_feed_lang.diff added

Fixed patch format and added documentation

comment:2 Changed 6 years ago by Luke Plant

Severity: Normal
Type: New feature

comment:3 Changed 5 years ago by Aymeric Augustin

Easy pickings: unset
Resolution: duplicate
Status: newclosed
UI/UX: unset

I'm closing this ticket in favor of #13896 which describes the same feature and has a more complete patch (with tests).

Note: See TracTickets for help on using tickets.
Back to Top