Opened 17 years ago
Closed 13 years ago
#7039 closed New feature (duplicate)
Feed 'language' is fixed to LANGUAGE_CODE - cann't work correct in multi-language site
Reported by: | oleksandr | Owned by: | nobody |
---|---|---|---|
Component: | contrib.syndication | Version: | dev |
Severity: | Normal | Keywords: | feed rss language |
Cc: | write@… | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | yes |
Needs tests: | no | Patch needs improvement: | yes |
Easy pickings: | no | UI/UX: | no |
Description
Feed 'language' is fixed to LANGUAGE_CODE - cannot work correct in multi-language site.
Should be asked as Feed class attribute first, to be able to define language in different site faces:
language = self.__get_dynamic_attr('language', obj) or settings.LANGUAGE_CODE.decode(),
Attachments (2)
Change History (5)
by , 17 years ago
Attachment: | patch_feedlang.diff added |
---|
comment:1 by , 17 years ago
Needs documentation: | set |
---|---|
Patch needs improvement: | set |
Triage Stage: | Unreviewed → Accepted |
Seems like a reasonable idea, but the patch needs improvement:
- The patch seems to be backwards, since it looks like you're trying to add the line that already exists.
- You are mixing tabs and spaces in the new code. Only spaces should be used for indentation.
- Also requires a change to the syndication documentation to explain the new feature.
by , 16 years ago
Attachment: | patch_feed_lang.diff added |
---|
Fixed patch format and added documentation
comment:2 by , 14 years ago
Severity: | → Normal |
---|---|
Type: | → New feature |
comment:3 by , 13 years ago
Easy pickings: | unset |
---|---|
Resolution: | → duplicate |
Status: | new → closed |
UI/UX: | unset |
I'm closing this ticket in favor of #13896 which describes the same feature and has a more complete patch (with tests).
Note:
See TracTickets
for help on using tickets.
feed language patch