Opened 5 years ago

Closed 4 years ago

#13897 closed (fixed)

There should be tests for object_list's pagination

Reported by: julien Owned by:
Component: Generic views Version:
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

As discussed on the dev-list (http://groups.google.com/group/django-developers/browse_thread/thread/629df2bddea57b7d) there currently are no tests for the object_list generic view's pagination functionality. The paginator is tested but only on its own.
There should be tests for it as it's probably used in many Django websites.

Attachments (2)

object_list_tests.diff (3.7 KB) - added by d0ugal 5 years ago.
13897.diff (3.5 KB) - added by SmileyChris 4 years ago.
PEP tidied patch

Download all attachments as: .zip

Change History (7)

Changed 5 years ago by d0ugal

comment:1 Changed 5 years ago by d0ugal

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

I have attached a patch with tests that cover the different code paths in the object_list view code paths.

comment:2 Changed 4 years ago by SmileyChris

  • Owner changed from nobody to SmileyChris
  • Triage Stage changed from Unreviewed to Accepted

Changed 4 years ago by SmileyChris

PEP tidied patch

comment:3 Changed 4 years ago by SmileyChris

  • Triage Stage changed from Accepted to Ready for checkin
  • Version 1.2 deleted

comment:4 Changed 4 years ago by SmileyChris

  • Owner SmileyChris deleted

comment:5 Changed 4 years ago by jezdez

  • Resolution set to fixed
  • Status changed from new to closed

(In [13965]) Fixed #13897 -- Added tests for pagination feature of the generic object_list view. Thanks, d0ugal and SmileyChris.

Note: See TracTickets for help on using tickets.
Back to Top