Opened 5 years ago

Closed 4 years ago

#13840 closed (fixed)

404 error reported via e-mail even when DEBUG is True

Reported by: master Owned by: nobody
Component: Core (Other) Version: master
Severity: Keywords: 404, broken link
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

According to http://docs.djangoproject.com/en/dev/howto/error-reporting/, "DEBUG is False" is one of the conditions for 404 errors to be reported via e-mail.
But they are, whatever the state of this setting.

The attached patch adds the mandatory condition.

Attachments (1)

404email.diff (700 bytes) - added by master 5 years ago.

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by master

comment:1 Changed 5 years ago by d0ugal

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

I noticed this behaviour this week and was surprised by it myself. I guess the decision here really is if the code is wrote on the documentation.

comment:2 Changed 5 years ago by kmtracey

  • Triage Stage changed from Unreviewed to Accepted

I'd say the code is wrong. Sending mail is generally the production behavior, for when the special debug 404 and 500 views are not available. If the debug 404 page has been sent as a response, then the mail should not be sent.

comment:3 Changed 4 years ago by julien

  • Resolution set to fixed
  • Status changed from new to closed

This has been reported again in #15187 and has been fixed.

Note: See TracTickets for help on using tickets.
Back to Top