Opened 14 years ago
Closed 14 years ago
#15187 closed (fixed)
CommonMiddleware should only send broken link emails if DEBUG is False
Reported by: | Dan Carroll | Owned by: | Dan Carroll |
---|---|---|---|
Component: | Core (Other) | Version: | 1.2 |
Severity: | Keywords: | common middleware | |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
According to the documentation on error reporting (see here: http://docs.djangoproject.com/en/dev/howto/error-reporting/), broken link emails are only sent if the following conditions are true (and CommonMiddleware is enabled):
- DEBUG is False
- SEND_BROKEN_LINK_EMAILS is True
Right now, CommonMiddleware.py only checks the second condition:
if settings.SEND_BROKEN_LINK_EMAILS: ...
In this case, I believe the best fix is to keep Django in line with the documentation, since broken link emails are unnecessary in an environment where DEBUG = True. Here is a quick look at the fix:
if settings.SEND_BROKEN_LINK_EMAILS and not settings.DEBUG: ...
Attachments (1)
Change History (7)
comment:1 by , 14 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:2 by , 14 years ago
Component: | Uncategorized → Core framework |
---|---|
Keywords: | common middleware added |
by , 14 years ago
Attachment: | 15187.diff added |
---|
comment:3 by , 14 years ago
comment:4 by , 14 years ago
Has patch: | set |
---|
comment:5 by , 14 years ago
Triage Stage: | Unreviewed → Ready for checkin |
---|
Low impact isn't really the measure here -- regardless of impact, every change *could* regress behavior, so it should be tested.
However, in this case, the behavior is something that is difficult to accurately test for regression, because debug is turned off for testing purposes. *That* is a good reason to accept the patch without a test.
comment:6 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Patch added, so fix is ready. No test was added, since this should be very low risk and low impact.