Code

Opened 4 years ago

Closed 4 years ago

#13830 closed (fixed)

Change one of province name in Indonesian localflavour

Reported by: rodin Owned by: anonymous
Component: contrib.localflavor Version: 1.2
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The name "Nanggroe Aceh Darussalam" province in django.contrib.localflavour.id.id_choices.py should be only "Aceh". The previous terms was only used until 2009. I also changed the 3 letter code to "ACE", to better reflect the current name.
Reference: http://id.wikipedia.org/wiki/Aceh#Referensi and http://www.dephut.go.id/files/Per_Gub_Aceh_46_09_0.pdf

Attachments (1)

id_choices.diff (731 bytes) - added by rodin 4 years ago.
Diff against r13402

Download all attachments as: .zip

Change History (6)

Changed 4 years ago by rodin

Diff against r13402

comment:1 Changed 4 years ago by anonymous

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to anonymous
  • Patch needs improvement unset
  • Status changed from new to assigned
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 4 years ago by jbronn

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [14195]) Fixed #13830 -- Updated province name in Indonesian localflavor. Thanks, rodin.

comment:3 Changed 4 years ago by jbronn

(In [14196]) [1.2.X] Fixed #13830 -- Updated province name in Indonesian localflavor. Thanks, rodin.

Backport of r14195 from trunk.

comment:4 Changed 4 years ago by kmtracey

  • Resolution fixed deleted
  • Status changed from closed to reopened

This change has introduced a test failure:

======================================================================
FAIL: localflavor_id_tests (regressiontests.forms.tests.__test__)
Doctest: regressiontests.forms.tests.__test__.localflavor_id_tests
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/kmtracey/django/trunk/django/test/_doctest.py", line 2180, in runTest
    raise self.failureException(self.format_failure(new.getvalue()))
AssertionError: Failed doctest test for regressiontests.forms.tests.__test__.localflavor_id_tests
  File "/home/kmtracey/django/trunk/tests/regressiontests/forms/tests.py", line unknown line number, in localflavor_id_tests

----------------------------------------------------------------------
File "/home/kmtracey/django/trunk/tests/regressiontests/forms/tests.py", line ?, in regressiontests.forms.tests.__test__.localflavor_id_tests
Failed example:
    s.render('provinces', 'LPG')
Expected:
    u'<select name="provinces">\n<option value="BLI">Bali</option>\n<option value="BTN">Banten</option>\n<option value="BKL">Bengkulu</option>\n<option value="DIY">Yogyakarta</option>\n<option value="JKT">Jakarta</option>\n<option value="GOR">Gorontalo</option>\n<option value="JMB">Jambi</option>\n<option value="JBR">Jawa Barat</option>\n<option value="JTG">Jawa Tengah</option>\n<option value="JTM">Jawa Timur</option>\n<option value="KBR">Kalimantan Barat</option>\n<option value="KSL">Kalimantan Selatan</option>\n<option value="KTG">Kalimantan Tengah</option>\n<option value="KTM">Kalimantan Timur</option>\n<option value="BBL">Kepulauan Bangka-Belitung</option>\n<option value="KRI">Kepulauan Riau</option>\n<option value="LPG" selected="selected">Lampung</option>\n<option value="MLK">Maluku</option>\n<option value="MUT">Maluku Utara</option>\n<option value="NAD">Nanggroe Aceh Darussalam</option>\n<option value="NTB">Nusa Tenggara Barat</option>\n<option value="NTT">Nusa Tenggara Timur</option>\n<option value="PPA">Papua</option>\n<option value="PPB">Papua Barat</option>\n<option value="RIU">Riau</option>\n<option value="SLB">Sulawesi Barat</option>\n<option value="SLS">Sulawesi Selatan</option>\n<option value="SLT">Sulawesi Tengah</option>\n<option value="SLR">Sulawesi Tenggara</option>\n<option value="SLU">Sulawesi Utara</option>\n<option value="SMB">Sumatera Barat</option>\n<option value="SMS">Sumatera Selatan</option>\n<option value="SMU">Sumatera Utara</option>\n</select>'
Got:
    u'<select name="provinces">\n<option value="ACE">Aceh</option>\n<option value="BLI">Bali</option>\n<option value="BTN">Banten</option>\n<option value="BKL">Bengkulu</option>\n<option value="DIY">Yogyakarta</option>\n<option value="JKT">Jakarta</option>\n<option value="GOR">Gorontalo</option>\n<option value="JMB">Jambi</option>\n<option value="JBR">Jawa Barat</option>\n<option value="JTG">Jawa Tengah</option>\n<option value="JTM">Jawa Timur</option>\n<option value="KBR">Kalimantan Barat</option>\n<option value="KSL">Kalimantan Selatan</option>\n<option value="KTG">Kalimantan Tengah</option>\n<option value="KTM">Kalimantan Timur</option>\n<option value="BBL">Kepulauan Bangka-Belitung</option>\n<option value="KRI">Kepulauan Riau</option>\n<option value="LPG" selected="selected">Lampung</option>\n<option value="MLK">Maluku</option>\n<option value="MUT">Maluku Utara</option>\n<option value="NTB">Nusa Tenggara Barat</option>\n<option value="NTT">Nusa Tenggara Timur</option>\n<option value="PPA">Papua</option>\n<option value="PPB">Papua Barat</option>\n<option value="RIU">Riau</option>\n<option value="SLB">Sulawesi Barat</option>\n<option value="SLS">Sulawesi Selatan</option>\n<option value="SLT">Sulawesi Tengah</option>\n<option value="SLR">Sulawesi Tenggara</option>\n<option value="SLU">Sulawesi Utara</option>\n<option value="SMB">Sumatera Barat</option>\n<option value="SMS">Sumatera Selatan</option>\n<option value="SMU">Sumatera Utara</option>\n</select>'

Easy enough to fix, but I don't think we can change the 3-letter code at this point -- does that not introduce a problem for anyone who has used the old list as the choices value for a model field? If they've got the old 3-letter value in the DB and we change it, we've made their current DB data invalid instead of just changing the province name that appears in the list.

comment:5 Changed 4 years ago by kmtracey

  • Resolution set to fixed
  • Status changed from reopened to closed

Re-closing in favor of #14455.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.