Code

Opened 4 years ago

Closed 3 years ago

#13829 closed New feature (wontfix)

EMAIL_CHARSET setting

Reported by: IanLewis Owned by: nobody
Component: Core (Mail) Version: 1.2
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: yes
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX:

Description

Add a EMAIL_CHARSET setting that allows you set the default encoding for emails.

Attachments (2)

email_charset.patch (2.8 KB) - added by IanLewis 4 years ago.
Patch for the EMAIL_CHARSET setting.
email_charset_with_option.patch (9.4 KB) - added by IanLewis 4 years ago.
A version of the patch which adds an encoding option to send_mail().

Download all attachments as: .zip

Change History (7)

Changed 4 years ago by IanLewis

Patch for the EMAIL_CHARSET setting.

comment:1 Changed 4 years ago by IanLewis

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

The setting defaults to the DEFAULT_CHARSET for ease of use and backwards compatibility.

Changed 4 years ago by IanLewis

A version of the patch which adds an encoding option to send_mail().

comment:2 Changed 3 years ago by dmoisset

  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Accepted

The feature looks valid and the patch looks ok in visual inspection. It's not applying anymore because doctests were converted to unittests. If somebody updates the test cases, this looks like something to check in.

Flagging as "Accepted" until tests are rewritten

comment:3 Changed 3 years ago by dmoisset

  • Needs documentation set

Documentation for the setting is also needed.

comment:4 Changed 3 years ago by graham_king

  • Severity set to Normal
  • Type set to New feature

comment:5 Changed 3 years ago by graham_king

  • Easy pickings unset
  • Resolution set to wontfix
  • Status changed from new to closed

Is an email specific encoding still needed, different from DEFAULT_CHARSET? And is it a common enough case to warrant it's own setting?

I think it's rare enough that we can use EmailMessage (which does support setting the encoding) directly in those cases. Given that there's been no activity in 6 months, and the patch would need updating anyway, I'm going to close. Please re-open as needed.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.