Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#12704 closed (duplicate)

Wrong interpretation of extra clause in ModelAdmin with new admin UI

Reported by: Russell Keith-Magee Owned by: nobody
Component: contrib.admin Version: master
Severity: Keywords:
Cc: Florian Apolloner Triage Stage: Design decision needed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The new javascript-enabled admin UI appears have an unusual interpretation of the 'extra' clause on a ModelAdmin.

The current code interprets 'extra = N' as "allow the user to add no more than N extra rows. The user must press (+ add another XXX) to add the first inline.

I would have thought the interpretation would have been "instantiate the form with with N empty extra rows". The task of constraining the number of allowed inlines is the job of the 'max_num' clause.

The admin UI should always show N blank inputs (for extra = N), as long as that wouldn't exceed the max_num. The user should be able to fill in up to N inlines before needing to press the (+ add another) button.

If I'm incorrect, then the second failing test reported by #12703 needs to be fixed by accounting for the 5 fields (and missing default date) that are no longer on the form.

Change History (4)

comment:1 Changed 7 years ago by Russell Keith-Magee

milestone: 1.2
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedDesign decision needed

comment:2 Changed 7 years ago by Russell Keith-Magee

Resolution: duplicate
Status: newclosed

Duplicate of #12692.

comment:3 Changed 7 years ago by Florian Apolloner

Cc: Florian Apolloner added

comment:4 Changed 5 years ago by Jacob

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top