?next linking to a login_required view doesn't work

[libwilliam]

On my site I link to a view that is login_required and the url has a next param in it.

mysite.com/some_view/?next=/some_other_view/

When it arrives at the login page it looks like this.

mysite.com/accounts/login/?next=some_view/?next=/some_other_view/

It cannot handle that url so it redirects to /accounts/profile/

[libwilliam]

I also have another related problem.

I have a url mysite.com/+item that goes to a login_required view. When it arrives at the /accounts/login/ url it looks like this. mysite.com/accounts/login/?next=/%2Bitem/... It then doesn't redirect to the correct spot. I am guessing because of the %2B Is there a way around this?

[Bruno Renié]

This looks invalid to me, the login template needs to look like this:

<form method="post" action="{% url login %}">
  {{ form.as_p }}
  {% if next %} {# this is REDIRECT_FIELD_NAME #}
  <input type="hidden" name="next" value="{{ next }}" />{% endif %}
  <input type="submit" value="Sign in" />
</form>

If the hidden input isn't added, there is no way the view can redirect to the right URL.

This is ​fully documented here (scroll down)

[James Bennett]

1.2 is feature-frozen, moving this feature request off the milestone.

[Jannis Leidel]

I believe this has been fixed a while ago.