Opened 15 years ago
Closed 15 years ago
#11923 closed (duplicate)
Suspected typo in django/db/models/sql/query.py
Reported by: | Greg Wogan-Browne | Owned by: | nobody |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | 1.1 |
Severity: | Keywords: | ||
Cc: | django@… | Triage Stage: | Unreviewed |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
I believe I have found a typo in [source:/django/tags/releases/1.1/django/db/models/sql/query.py django/db/models/sql/query.py] at line 1400.
This line causes a TypeError ("update() takes exactly one argument (2 given)"
). Looking at it, and the surrounding code (specifically line 1417) I believe the intent is instead of:
avoid.update(self.dupe_avoidance.get(id(opts), lhs_col),())
it should actually be:
avoid.update(self.dupe_avoidance.get((id(opts), lhs_col),()))
Attachments (1)
Change History (3)
comment:1 by , 15 years ago
Cc: | added |
---|---|
Has patch: | set |
by , 15 years ago
Attachment: | django-ticket-11923.patch added |
---|
comment:2 by , 15 years ago
Resolution: | → duplicate |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Duplicate of #11764.