Bugfix: typo with avoid.update(..) in db/models/sql/compiler.py:SQLCompiler:fill_related_selections

[Aurelio Tinio]

There looks to be a bug due to a typo in db/models/sql/query.py .

The issue became apparent when it prevented the display of a ForeignKey field in list_display, when there is another ForeignKey to the base class of the model with the following error displayed:

Caught an exception while rendering: update() takes exactly one argument (2 given)

Original Traceback (most recent call last):
  File "/tippit/django-projects/django/Django-1.1/django/template/debug.py", line 71, in render_node
    result = node.render(context)
  File "/tippit/django-projects/django/Django-1.1/django/template/__init__.py", line 936, in render
    dict = func(*args)
  File "/tippit/django-projects/django/Django-1.1/django/contrib/admin/templatetags/admin_list.py", line 253, in result_list
    'results': list(results(cl))}
  File "/tippit/django-projects/django/Django-1.1/django/contrib/admin/templatetags/admin_list.py", line 247, in results
    for res in cl.result_list:
  File "/tippit/django-projects/django/Django-1.1/django/db/models/query.py", line 106, in _result_iter
    self._fill_cache()
  File "/tippit/django-projects/django/Django-1.1/django/db/models/query.py", line 692, in _fill_cache
    self._result_cache.append(self._iter.next())
  File "/tippit/django-projects/django/Django-1.1/django/db/models/query.py", line 238, in iterator
    for row in self.query.results_iter():
  File "/tippit/django-projects/django/Django-1.1/django/db/models/sql/query.py", line 287, in results_iter
    for rows in self.execute_sql(MULTI):
  File "/tippit/django-projects/django/Django-1.1/django/db/models/sql/query.py", line 2360, in execute_sql
    sql, params = self.as_sql()
  File "/tippit/django-projects/django/Django-1.1/django/db/models/sql/query.py", line 395, in as_sql
    self.pre_sql_setup()
  File "/tippit/django-projects/django/Django-1.1/django/db/models/sql/query.py", line 589, in pre_sql_setup
    self.fill_related_selections()
  File "/tippit/django-projects/django/Django-1.1/django/db/models/sql/query.py", line 1401, in fill_related_selections
    ())
TypeError: update() takes exactly one argument (2 given)

A patch has been attached applied against changeset 11475.

[Ramiro Morales]

Same code patch plus regression test

[Ramiro Morales]

Finally got around to reproduce this corner case thing by tracing and copying the treatment the queryset gets in the admin app to show a change list for the relevant model (there is no need to create model instances at all). Critical to make the bug show itself are the select_related() call and iterating over the QS (forcing its evaluation with list() doesn't trigger it).

[Greg Wogan-Browne]

Updated patch against rev12438

[Greg Wogan-Browne]

Updated patch as the typo had moved from [source:django/trunk/django/db/models/sql/query.py query.py] to [source:django/trunk/django/db/models/sql/compiler.py compiler.py].

[Ramiro Morales]

Replying to wogan:

Updated patch as the typo had moved from [source:django/trunk/django/db/models/sql/query.py query.py] to [source:django/trunk/django/db/models/sql/compiler.py compiler.py].

Thanks for updating the patch. I had spotted the code move and implemented a simliar updating locally. Problem is that the regression test case I had added now pass with and without the fix applied. I ran the full Django test suite with code coverage analysis turned on and it shows that exact code path isn't exercised anymore.

This means we need to update the test because the core committers won't get this change in without a regression test. But I don't know if it's possible at all.

Sorry for not updating the ticket, I only made a comment about this on the #django-dev IRC channel.

[Alex Gaynor]

Moving off of RFC since ramiro notes that we can longer reproduce this :/

[Russell Keith-Magee]

Not critical for 1.2

[Greg Wogan-Browne]

Updated patch against rev13018

[Greg Wogan-Browne]

Updated the patch, made a minor change to the test.

I could successfully run the test (failing appropriately when the patch is not applied).

Is it possible to get this in for 1.2?

[Russell Keith-Magee]

(In [13019]) Fixed #11764 -- Added a missing set of parentheses in a call calculating the select_related tables. Thanks to aurelio for the report and original patch, and wogan for the updated patch.

[Jacob]

Milestone 1.2 deleted