#11765 closed Uncategorized (invalid)
models.DateField(null=True, blank=True) accepts None, but not the empty string ''
Reported by: | shmengie | Owned by: | nobody |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | no | Needs documentation: | no |
Needs tests: | yes | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
For some reason I cannot create a record with
class MyModel(models.Model): models.DateField(null=True, blank=True) MyModel(MyDateField='')
It must be either None or a valid date.
Change History (9)
comment:1 by , 15 years ago
Summary: | models.DateField(null=True, blank=True) accepts None, but not null string '' → models.DateField(null=True, blank=True) accepts None, but not the empty string '' |
---|
follow-up: 4 comment:2 by , 15 years ago
Component: | Uncategorized → Database layer (models, ORM) |
---|---|
Needs tests: | set |
Version: | 1.1 → SVN |
comment:3 by , 15 years ago
Resolution: | → invalid |
---|---|
Status: | new → closed |
blank=True tells user that they don't have to fill this field, and it doesn't mean that its empty string. Django assign NoneType if empty.
comment:4 by , 15 years ago
Description: | modified (diff) |
---|
Replying to mrts:
The problem is that
DateField.to_python()
(orDateTimeField
) doesn't treat''
specially...
Neither does IntegerField nor FloatField, eg. It's not clear to me why Date fields would/should be singled out for special treatment here. Forms fields consistently handle treating empty strings input as None, but if you are operating at the model level then you need to use None when you mean None, not an empty string.
follow-up: 7 comment:5 by , 15 years ago
i've got the ValidationError exception in django's own create_update generic view. a ModelForm instance validates fine, but the save() method raises exactly this exception. there's a simple workaround, but IMHO it should be performed by the field instance.
def clean(self): cleaned_data = self.cleaned_data end_time = cleaned_data.get('end_time') # this is not None if user left the <input/> empty # ... do stuff with data if not end_time: cleaned_data['end_time'] = None return cleaned_data
not sure if it warrants a different ticket.
comment:6 by , 15 years ago
In case it helps anyone else tearing their hair out, here's one other thing to check (see Stack Overflow ticket): if you have any default or helper text in the field, that will blow up on validation before you get to the clean() method.
comment:7 by , 12 years ago
Easy pickings: | unset |
---|---|
Severity: | → Normal |
Type: | → Uncategorized |
UI/UX: | unset |
I agree, I just fixed my problem by adding
def clean(self): cleaned_data = super(MyForm, self).clean() if not cleaned_data['my_date']: cleaned_data['my_date'] = None return cleaned_data
to my form. Without this I received the error
ValidationError: [u"'' value has an invalid date format. It must be in YYYY-MM-DD format."]
even though I had blank=True, null=True set in my model and required=False set in my form.
comment:8 by , 11 years ago
I got this error using crispy-forms and not specifying my Date field in Meta.fields. Adding a clean()n method didn't help but adding the Date field back to Meta.fields did.
The problem is that
DateField.to_python()
(orDateTimeField
) doesn't treat''
specially, see source:/django/trunk/django/db/models/fields/__init__.py@10545#L464