Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#10886 closed (fixed)

"Reversing Admin URLs" section provides invalid examples

Reported by: Simon Meers <DrMeers@…> Owned by: Jacob
Component: Documentation Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

urlresolvers.reverse('admin_polls_choice_change', (c.id,))

should be:

urlresolvers.reverse('admin_polls_choice_change', args=[c.id,])

otherwise (c.id,) is interpreted as the urlconf argument, and an error such as:

AttributeError: 'int' object has no attribute 'regex'

is raised, since (c.id,) is not a urlconf. The second example with custom_admin_... should also be changed.

Attachments (1)

reverse.patch (752 bytes) - added by dc 7 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by Alex Gaynor

milestone: 1.1
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

Changed 7 years ago by dc

Attachment: reverse.patch added

comment:2 Changed 7 years ago by George Song

Has patch: set

comment:3 Changed 7 years ago by Andy Durdin

Triage Stage: AcceptedReady for checkin

comment:4 Changed 7 years ago by Jacob

Owner: changed from nobody to Jacob
Status: newassigned

comment:5 Changed 7 years ago by Alex Gaynor

Resolution: fixed
Status: assignedclosed

Fixed in r10776.

comment:6 Changed 5 years ago by Jacob

milestone: 1.1

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top