Opened 16 years ago
Closed 15 years ago
#10887 closed (fixed)
admin.autodiscover
Reported by: | Luc Saffre | Owned by: | nobody |
---|---|---|---|
Component: | contrib.admin | Version: | 1.0 |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
In django/contrib/admin/__init__.py
, I suggest to change the following code:
try: app_path = import_module(app).__path__ except AttributeError: continue
into:
mod = import_module(app) try: app_path = mod.__path__ except AttributeError: continue
Otherwise there is a probably not intended behaviour if one of my modules is buggy and raises itself an AttributeError.
Attachments (1)
Change History (3)
by , 16 years ago
Attachment: | 10887.diff added |
---|
comment:1 by , 16 years ago
Triage Stage: | Unreviewed → Ready for checkin |
---|
comment:2 by , 15 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Agreed