Consistency between HttpResponse* params and render_to_response
|Reported by:||Brent Hagany||Owned by:||nobody|
|Cc:||brent.hagany@…, Riccardo Attilio Galli||Triage Stage:||Accepted|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||yes|
I was just browsing through some of the Django code and came across the new-ish (to me) addition of the content_type alias for the mimetype parameter to HttpResponse and company. Wondering about the rationale behind this decision, I came across ticket #3526, which may be helpful to review in evaluating this ticket.
In light of this, (and just for consistency) I thought it would probably be a good idea to allow render_to_response to pass content_type along to HttpResponse. I'll attach a simple patch that does this.
Also, this patch will conflict with another patch (#9081) I've submitted that has been accepted but not yet committed. It'll be very easy to resolve, but I'm unsure if I should take any special measures about this.
Change History (19)
comment:15 Changed 5 years ago by
|Cc:||Riccardo Attilio Galli added|
comment:16 Changed 5 years ago by
|Patch needs improvement:||set|
|Status:||closed → reopened|