#19692 closed Cleanup/optimization (fixed)
Replace HttpResponse.mimetype (deprecated) with content_type in doc examples
Reported by: | Tim Graham | Owned by: | Aymeric Augustin |
---|---|---|---|
Component: | Documentation | Version: | dev |
Severity: | Release blocker | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
I'm assuming we're also deprecating the mimetype
argument on TemplateResponse
and SimpleTemplateResponse
? Alternatively, we'd have to add a shim to continue supporting mimetype
for these classes once mimetype
is removed from HttpResponse.__init__
.
Attachments (2)
Change History (10)
by , 12 years ago
Attachment: | 19692.diff added |
---|
comment:1 by , 12 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:3 by , 12 years ago
Severity: | Normal → Release blocker |
---|
We should at least make a decision before the release!
comment:4 by , 12 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
And that decision is to proceed with the deprecation.
by , 12 years ago
Attachment: | 19692-2.diff added |
---|
comment:5 by , 12 years ago
I completed Tim's documentation patch by adding DeprecationWarnings
and updating remaining instances of mimetype
in the code base.
This patch is for master. When backporting to 1.5, DeprecationWarning
must be replaced with PendingDeprecationWarning
.
comment:6 by , 12 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
I noticed that inconsistency a few days ago too. It isn't ideal to add a deprecation after RC1, but for the sake of consistency, +1.