Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#9985 closed (fixed)

r9701 breaks for combinations of values_list and unique - it inserts duplicate references in SQL

Reported by: cmutel@… Owned by: Malcolm Tredinnick
Component: Database layer (models, ORM) Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


r9701 introduces a change that leads to malformed SQL in queries that include values_list and distinct queries, at least in SQLite. A simple example:

class Database(models.Model):
    name = models.TextField()

class Process(models.Model):
    database = models.ForeignKey(Database)
    name = models.TextField()

The query

'database', flat=True).distinct()) 

produces the following SQL:

SELECT "basic_database"."id", "basic_database"."name" FROM "basic_database" WHERE 
"basic_database"."id" IN (SELECT DISTINCT U0."database_id", U0."database_id" FROM 
"basic_process" U0 WHERE U0."id" IN (1, 2)) LIMIT 21

where U0."database_id" is repeated, and produces an error:

OperationalError: only a single result allowed for a SELECT that is part of an expression

Unfortunately, this is the limit of my Python knowledge, so I don't have a patch to correct this problem.

The query functions perfectly in r9700 and earlier.

Change History (3)

comment:1 Changed 11 years ago by Malcolm Tredinnick

Owner: changed from nobody to Malcolm Tredinnick
Status: newassigned

That query cannot possibly come from the queryset you specify, since that queryset will never generate a limit. It's close, though, and does demonstrate a problem.

The root issue is that qs.values_list(...).values(....) doesn't work properly, which needs fixing.

comment:2 Changed 11 years ago by Malcolm Tredinnick

Resolution: fixed
Status: assignedclosed

(In [9717]) Fixed #9985 -- qs.values_list(...).values(...) was constructing incorrect SQL.

comment:3 Changed 10 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top