Opened 15 years ago

Last modified 12 years ago

#9967 closed

Comment's get_absolute_url anchor doesn't work in Safair — at Version 3

Reported by: msm Owned by: nobody
Component: Documentation Version: 1.0
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description (last modified by Alex Gaynor)

Maybe I'm wrong, but calling get_absolute_url on a comment is redirected to this:

16	urlpatterns += patterns('',
17	    url(r'^cr/(\d+)/(\w+)/$', 'django.views.defaults.shortcut', name='comments-url-redirect'),
18	)

In my case this somehow doesnt return the anchor of a comment (so that the browser directly jumps to the comment text (e.g. /slug-of-article/#c123

EDIT: We just need to document that the anchor is lost on redirect in Safari (works in Firefox and Chrome. IE status unkown).

Change History (3)

comment:1 by Jacob, 15 years ago

Resolution: invalid
Status: newclosed

This works just fine for me.

comment:2 by Idan Gazit, 15 years ago

Resolution: invalid
Status: closedreopened

This is a bug in webkit (aka Safari): https://bugs.webkit.org/show_bug.cgi?id=24175

Web servers don't understand anchors because they're not part of proper URLs. Nominally, the browser is supposed to remember the named anchor, and reapply it after the redirect.

Safari doesn't behave correctly, and "forgets" the named anchor. In the case of the comments framework, this means that Safari browsers will end up on the right page but not at the anchor.

comment:3 by Alex Gaynor, 15 years ago

Component: django.contrib.commentsDocumentation
Description: modified (diff)
Summary: get_absolute_url doesn't add anchor to urlComment's get_absolute_url anchor doesn't work in Safair
Triage Stage: UnreviewedAccepted

Edited title, added a note to the description describing the new reality.

Note: See TracTickets for help on using tickets.
Back to Top