Opened 14 years ago
Closed 11 years ago
#9967 closed Cleanup/optimization (fixed)
Comment's get_absolute_url anchor doesn't work in Safari
| Reported by: | msm | Owned by: | nobody |
|---|---|---|---|
| Component: | Documentation | Version: | 1.0 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
Maybe I'm wrong, but calling get_absolute_url on a comment is redirected to this:
16 urlpatterns += patterns('',
17 url(r'^cr/(\d+)/(\w+)/$', 'django.views.defaults.shortcut', name='comments-url-redirect'),
18 )
In my case this somehow doesnt return the anchor of a comment (so that the browser directly jumps to the comment text (e.g. /slug-of-article/#c123
EDIT: We just need to document that the anchor is lost on redirect in Safari (works in Firefox and Chrome. IE status unkown).
Attachments (1)
Change History (10)
comment:1 Changed 14 years ago by
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
comment:2 Changed 14 years ago by
| Resolution: | invalid |
|---|---|
| Status: | closed → reopened |
This is a bug in webkit (aka Safari): https://bugs.webkit.org/show_bug.cgi?id=24175
Web servers don't understand anchors because they're not part of proper URLs. Nominally, the browser is supposed to remember the named anchor, and reapply it after the redirect.
Safari doesn't behave correctly, and "forgets" the named anchor. In the case of the comments framework, this means that Safari browsers will end up on the right page but not at the anchor.
comment:3 Changed 14 years ago by
| Component: | django.contrib.comments → Documentation |
|---|---|
| Description: | modified (diff) |
| Summary: | get_absolute_url doesn't add anchor to url → Comment's get_absolute_url anchor doesn't work in Safair |
| Triage Stage: | Unreviewed → Accepted |
Edited title, added a note to the description describing the new reality.
comment:4 Changed 14 years ago by
| Summary: | Comment's get_absolute_url anchor doesn't work in Safair → Comment's get_absolute_url anchor doesn't work in Safari |
|---|
Changed 14 years ago by
| Attachment: | r10753_comment_linking_docs.diff added |
|---|
comment:5 Changed 14 years ago by
previous patch incorrectly separated the ".. templatetag:: get_comment_count" and the "Counting Comments" section.
comment:6 Changed 12 years ago by
| Has patch: | set |
|---|---|
| Patch needs improvement: | set |
| Severity: | → Normal |
| Type: | → Cleanup/optimization |
May as well reference the webkit bug url in our docs
comment:9 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
This works just fine for me.