Generic view "redirect_to" to carry existing query string

[FilipeCorreia]

The "redirect_to" generic view currently does not pass along any query string that may exist in the original request.

An extra parameter could be added to "redirect_to", specifying if the original query string should be appended or not. See the following thread:
​http://groups.google.com/group/django-users/browse_frm/thread/4566f4040cef518a/8bfcd6ddd4ebb9f5

[Jacob]

I'd expect the query string to *always* be passed through, actually; no need for an option.

[steingrd]

I added a patch that passes through query strings on redirect in django.views.generic.simple.redirect_to.

I've also written a test case for the redirect_to view, unfortunately it shows up as a file named /dev/null in my patch, the filename is tests/regressiontests/views/tests/generic/simple.py. The feature broke a few tests in regressiontests/test_client_regress/models.py, these have been updated as well.

I haven't updated the documentation as English is not my first language.

[Malcolm Tredinnick]

Have to say, I disagree with Jacob's comment:2. Inthe general case, it's not going to be correct to pass through the query string. That string is specific to the particular resource requested, not all resources that the site serves and redirect is redirecting to a different resource. It's appropriate to pass on the query string when, say, redirecting to a canonical URL form (e.g. appending a slash to the URL), but, in general, no, it's not.

I'd be -1 on making this behave this way always. As an option, though, it's absolutely a good idea.

[steingrd]

adds a query_string optional keyword arg to redirect_to

[steingrd]

I actually agree with Malcolm, the query string should only follow when configured to so. I have created a new patch that adds a query_string keyword argument to the redirect_to function.

I've added the option to the generic views reference documentation and updated all tests.

[steingrd]

Patch that applies cleanly to r11688

[Eric Holscher]

Patch looks good to me.

[James Bennett]

1.2 is feature-frozen, moving this feature request off the milestone.

[Malcolm Tredinnick]

(In [13746]) Add option to redirect_to view to allow passing along the query string
from the original request. Default is current behaviour, which is not to
pass the query string (it often won't be appropriate to do so).

Thanks to steingrd@… for the patch and tests. Fixed #9966.

[Claude Paroz]

Shouldn't the doc mention that this was added in dev version?