Code

Opened 6 years ago

Closed 4 years ago

Last modified 3 years ago

#9764 closed (fixed)

IDN (Internationalized Domain Names) support for EmailField and URLField

Reported by: UloPe Owned by: jezdez
Component: Forms Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Currently EmailField and URLField don't accept values that contain IDNs.

The submitted patch adds this capability.

Attachments (2)

idn_support.diff (3.6 KB) - added by UloPe 6 years ago.
EmailField, URLField IDN support
idn_support_02.diff (7.6 KB) - added by UloPe 4 years ago.
Updated IDN patch to trunk (r12454); Added docs

Download all attachments as: .zip

Change History (14)

Changed 6 years ago by UloPe

EmailField, URLField IDN support

comment:1 Changed 5 years ago by jacob

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

comment:2 Changed 5 years ago by Emil Stenström

I just had to add verify_exists = False on a URLField because users complained that they couldn't use IDN fields. This patch seem very well architected, and solves a common annoyance (for me).

+1

comment:3 Changed 4 years ago by jezdez

  • milestone set to 1.2
  • Owner changed from nobody to jezdez
  • Status changed from new to assigned
  • Triage Stage changed from Design decision needed to Accepted

comment:4 Changed 4 years ago by jezdez

  • Needs documentation set

comment:5 Changed 4 years ago by rlaager@…

What documentation is needed here? Just the fact that IDN is supported as of Django version 1.2?

comment:6 Changed 4 years ago by jezdez

Yes, please add a versionadded: 1.2 section.

Changed 4 years ago by UloPe

Updated IDN patch to trunk (r12454); Added docs

comment:7 Changed 4 years ago by UloPe

  • Needs documentation unset

I've updated the patch for current trunk (r12454) and added a short note on the EmailFiled/URLField documentation.

comment:8 Changed 4 years ago by jezdez

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [12474]) Fixed #9764 - Updated EmailField and URLField to support IDN (Internationalized Domain Names). Thanks, UloPe.

comment:9 follow-up: Changed 4 years ago by bjunix

Are there plans to backport this patch to 1.1.X ?

comment:10 in reply to: ↑ 9 ; follow-up: Changed 4 years ago by kmtracey

Replying to bjunix:

Are there plans to backport this patch to 1.1.X ?

No. The doc contains version changed flags indicating the new behavior in 1.2, that implies it won't be added to 1.1.X.

comment:11 in reply to: ↑ 10 Changed 4 years ago by bjunix

Replying to kmtracey:

No. The doc contains version changed flags indicating the new behavior in 1.2, that implies it won't be added to 1.1.X.

Ok, I see. Thanks for your answer. Hoped this one would fall under bugfixes.

comment:12 Changed 3 years ago by jacob

  • milestone 1.2 deleted

Milestone 1.2 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.