Opened 8 years ago

Last modified 3 years ago

#9757 new Cleanup/optimization

Make IfNode a baseclass for other if nodes to subclass

Reported by: Alex Gaynor Owned by: nobody
Component: Template system Version: 1.0
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Right now any other if type node that wants to exist needs to re-implement all the rendering logic of the if tag, in addition to the conditional it wants to use. To simplify this we could make IfNode do all of the logic to determine whether it evalueates true or not into a seperate method, and then subclasses could just overide the init and that mehtod.

Change History (7)

comment:1 Changed 8 years ago by Johannes Dollinger

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

#7806 has a ConditionalNode in django.template.utils that does exactly that.

comment:2 Changed 8 years ago by Alex Gaynor

Great, I hadn't noticed that in that behemoth of that patch :P . I'm going to leave this open still as a marker ticket for this, even if it will be handled as a part of that.

comment:3 Changed 8 years ago by Jacob

Triage Stage: UnreviewedAccepted

comment:4 Changed 5 years ago by Luke Plant

Severity: Normal
Type: Cleanup/optimization

comment:5 Changed 5 years ago by Aymeric Augustin

UI/UX: unset

Change UI/UX from NULL to False.

comment:6 Changed 5 years ago by Aymeric Augustin

Easy pickings: unset

Change Easy pickings from NULL to False.

comment:7 Changed 3 years ago by jonathanslenders

Note: See TracTickets for help on using tickets.
Back to Top