#9666 closed (fixed)
ssi tag don't works with context variables
| Reported by: | Andrews Medina | Owned by: | Eric Holscher |
|---|---|---|---|
| Component: | Template system | Version: | dev |
| Severity: | Keywords: | tag, ssi, template | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | yes | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
if I want use this:
{% ssi url %}
and url to be a context variable, this don't works. The tag {% ssi %} works only with strings.
Attachments (5)
Change History (16)
by , 16 years ago
| Attachment: | patche.txt added |
|---|
comment:1 by , 16 years ago
| Version: | 1.0 → SVN |
|---|
comment:2 by , 16 years ago
| milestone: | → 1.1 |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:3 by , 16 years ago
comment:4 by , 16 years ago
| Needs tests: | set |
|---|
comment:5 by , 16 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
Note that currently I don't see any tests associated with ssi. I'll work on this later, if nobody else wants to.
by , 16 years ago
| Attachment: | 9666-with-tests.2.diff added |
|---|
'"' +This makes me cry a little inside + '"'
comment:7 by , 14 years ago
| milestone: | → 1.3 |
|---|
comment:8 by , 14 years ago
comment:10 by , 14 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
The above patch has a bug if the ssi tag is used with a variable inside a loop.
Since the variable is only "resolved" once subsequent .render() calls (to the same node) always return the result of the first invocation.
I'll attach a fixed patch.