Opened 10 years ago

Closed 10 years ago

Last modified 8 years ago

#9665 closed (fixed)

Formset::_get_ordered_forms() code documentation incorrectly describes logic.

Reported by: mark_hildreth Owned by: nobody
Component: Forms Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


The code comment for _get_ordered_forms (django/forms/, line: 142-143), reads as followed:

Returns a list of form in the order specified by the incoming data.
Raises an AttributeError if deletion is not allowed.

This should say that it raises an AttributeError if ordering is not allow.

Attachments (1)

GetOrderedFormsComment.patch (639 bytes) - added by mark_hildreth 10 years ago.

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by mark_hildreth

comment:1 Changed 10 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

comment:2 Changed 10 years ago by Jacob

milestone: 1.1
Triage Stage: UnreviewedAccepted

comment:3 Changed 10 years ago by jkocherhans

Resolution: fixed
Status: newclosed

(In [10206]) Fixed #9587. Formset.is_valid() now returns True if an invalid form is marked for deletion. Thanks for the test and intial patch, kratorius.
Note that this leaves the form and formset errors alone. Those forms still have errors, it's just that it doesn't matter that they're invalid in the context of the formset and deletion.
Also fixed #9665 while I was in there. Thanks, mark_hildreth.

comment:4 Changed 8 years ago by Jacob

milestone: 1.1

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top