#9665 closed (fixed)
Formset::_get_ordered_forms() code documentation incorrectly describes logic.
| Reported by: | mark_hildreth | Owned by: | nobody |
|---|---|---|---|
| Component: | Forms | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The code comment for _get_ordered_forms (django/forms/formsets.py, line: 142-143), reads as followed:
Returns a list of form in the order specified by the incoming data.
Raises an AttributeError if deletion is not allowed.
This should say that it raises an AttributeError if ordering is not allow.
Attachments (1)
Change History (5)
by , 15 years ago
| Attachment: | GetOrderedFormsComment.patch added |
|---|
comment:1 by , 15 years ago
| milestone: | post-1.0 |
|---|
comment:2 by , 15 years ago
| milestone: | → 1.1 |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:3 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [10206]) Fixed #9587. Formset.is_valid() now returns True if an invalid form is marked for deletion. Thanks for the test and intial patch, kratorius.
Note that this leaves the form and formset errors alone. Those forms still have errors, it's just that it doesn't matter that they're invalid in the context of the formset and deletion.
Also fixed #9665 while I was in there. Thanks, mark_hildreth.
Note:
See TracTickets
for help on using tickets.
Milestone post-1.0 deleted