No output from `wsgi.file_wrapper`

[Jonas Borgström]

The development server exposes the wsgi.file_wrapper extension but a typo in ServerHandler.finish_responsestops any file contents from making it to the browser.

django/core/servers/basehttp.py

@@ -313 +313 @@
         in the event loop to iterate over the data, and to call
         'self.close()' once the response is finished.
         """
-        if not self.result_is_file() and not self.sendfile():
+        if not self.result_is_file() or not self.sendfile():
             for data in self.result:
                 self.write(data)
             self.finish_content()

[Thomas Güttler]

Ticket #7894 does this change, too.

[Armin Ronacher]

Applied the fix and created a testcase.

[Armin Ronacher]

The latter has a better name for the tests. (basehttp_server)

[Jacob]

(In [10690]) Fixed #9659: fixed wsgi.file_wrapper in the builtin server. Thanks, mitsuhiko.

[Jacob]

(In [10691]) [1.0.X] Fixed #9659: fixed wsgi.file_wrapper in the builtin server. Thanks, mitsuhiko. Backport of [10690] from trunk.

[Jacob]

Milestone 1.1 deleted