Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#9614 closed (invalid)

contrib.comments requires Authentication middleware

Reported by: anonymous Owned by: nobody
Component: Documentation Version: master
Severity: Keywords: contrib.comments authentication middleware
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

contrib.comments requires that the Authentication middleware is used. I suggest checking if request has attribute user could be nice for people that don't use the auth middleware and wishes to use the comments contrib

Attachments (2)

comments.patch (878 bytes) - added by anonymous 7 years ago.
patch checking if request has an attribute user
9614.diff (669 bytes) - added by thejaswi_puthraya 7 years ago.
git-patch against latest checkout

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by anonymous

patch checking if request has an attribute user

comment:1 Changed 7 years ago by thejaswi_puthraya

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Version changed from 1.0 to SVN

I am tagging this a documentation request because this requires the django.core.context_processors.request to be enabled in the settings. Your patch is almost reimplementing the context processor.

Changed 7 years ago by thejaswi_puthraya

git-patch against latest checkout

comment:2 Changed 7 years ago by thejaswi_puthraya

  • Component changed from django.contrib.comments to Documentation
  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 7 years ago by thejaswi_puthraya

  • Resolution set to invalid
  • Status changed from new to closed

On second thoughts, this ticket is invalid and I need to tell myself not to triage so late in the night.

comment:4 Changed 6 years ago by anonymous

  • milestone post-1.0 deleted

Milestone post-1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top