Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#9614 closed (invalid)

contrib.comments requires Authentication middleware

Reported by: anonymous Owned by: nobody
Component: Documentation Version: master
Severity: Keywords: contrib.comments authentication middleware
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

contrib.comments requires that the Authentication middleware is used. I suggest checking if request has attribute user could be nice for people that don't use the auth middleware and wishes to use the comments contrib

Attachments (2)

comments.patch (878 bytes) - added by anonymous 8 years ago.
patch checking if request has an attribute user
9614.diff (669 bytes) - added by Thejaswi Puthraya 8 years ago.
git-patch against latest checkout

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by anonymous

Attachment: comments.patch added

patch checking if request has an attribute user

comment:1 Changed 8 years ago by Thejaswi Puthraya

Version: 1.0SVN

I am tagging this a documentation request because this requires the django.core.context_processors.request to be enabled in the settings. Your patch is almost reimplementing the context processor.

Changed 8 years ago by Thejaswi Puthraya

Attachment: 9614.diff added

git-patch against latest checkout

comment:2 Changed 8 years ago by Thejaswi Puthraya

Component: django.contrib.commentsDocumentation
Triage Stage: UnreviewedAccepted

comment:3 Changed 8 years ago by Thejaswi Puthraya

Resolution: invalid
Status: newclosed

On second thoughts, this ticket is invalid and I need to tell myself not to triage so late in the night.

comment:4 Changed 8 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top