FormWizard doesn't work with NullableBooleanField

[LZ]

Create a series of forms. Make the first one contain a NullableBooleanField. Then, place the forms in a (contrib.formtools.) Wizard.

If the user set the value of the field to "True", it will succeed on the first submit. However, when there is a second submit, it will fail with a cryptic Exception message. It turns out that there's a render_hash_failure.

This is my first time trying Django, so I only have a few hours experience, but I think the problem comes from

​http://code.djangoproject.com/browser/django/trunk/django/contrib/formtools/utils.py :
19 data = [(bf.name, bf.field.clean(bf.data) or ) for bf in form]

Thank you!

[LZ]

I meant NullBooleanField, BTW. Sorry for the error.

[LZ]

I debugged this further. It turns out what widgets.NullBooleanSelect.value_from_datadict(self, data, files, name) needs to accept the 'True' and 'False' string values in addition to the True and False boolean values.

[(none)]

Milestone post-1.0 deleted

[Bob Thomas]

This is similar to #9336, which describes a similar problem for CheckboxInput

[Keith Bussell]

Fix and test

[Keith Bussell]

I applied the change suggested by LZ and added a test.

[Jacob]

Actually, maybe you can pull the info you need out of the context instead of using that regex. Take a look; I'm bumping this back out of rfc.

[Bob Thomas]

This isn't really a bug in FormWizard. I don't think the regression tests have to involve it at all; you can just test the widget/field directly. See patch on #9336

[Keith Bussell]

Same fix, new test

[Keith Bussell]

fix_9473_2.diff updates the test to use the previous_fields context member instead of parsing the whole html response. Also broke up the test function a bit to make it more reusable for other tests in the future.

[Jacob]

(In [10316]) Fixed #9473: FormWizard now works with NullBooleanFields. As a bonus, we now have the beginnings of a test suite for FormWizard. Thanks, Keith Bussell.

[Jacob]

(In [10321]) [1.0.X] Fixed #9473: FormWizard now works with NullBooleanFields. As a bonus, we now have the beginnings of a test suite for FormWizard. Thanks, Keith Bussell. Backport of r10316 and r10319 from trunk.

[Jacob]

Milestone 1.1 deleted