Code

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#9472 closed (fixed)

Corrections to URL dispatcher documentation

Reported by: daveyjoe Owned by: nobody
Component: Documentation Version: 1.0
Severity: Keywords: url dispatcher docs
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description (last modified by ramiro)

Noticed on: http://docs.djangoproject.com/en/dev/topics/http/urls/#id2 (django/trunk/docs/topics/http/urls.txt)

  1. URL's are missing the caret character ^ at the start of the regex.
  2. name="full-archive" was giving me a syntax error.

Attachments (1)

urls.txt.diff (1.2 KB) - added by daveyjoe 5 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 in reply to: ↑ description Changed 5 years ago by daveyjoe

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Replying to daveyjoe:

  1. name="full-archive" was giving me a syntax error.

Please disregard the second correction, I didn't notice that the url function was being used.

Changed 5 years ago by daveyjoe

comment:2 Changed 5 years ago by ramiro

  • Description modified (diff)

(reformatted description)

comment:3 Changed 5 years ago by mtredinnick

Incidentally, the leading carat isn't required, it just happens to be useful almost always to root the pattern search to the start of the string (there are cases where that might not be desirable, though). The leading forwards slash was definitely going to cause problems, though.

Please create patches from the top of the subversion checkout so that we don't have to hunting for where the particular file is that needs patching. Thanks for the patch, anyway.

comment:4 Changed 5 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [9471]) Fixed #9472 -- Fixed a couple of URL patterns to be more consistent (and remove
a misleading initial slash). Thanks, daveyjoe.

comment:5 Changed 5 years ago by mtredinnick

(In [9472]) [1.0.X] Fixed #9472 -- Fixed a couple of URL patterns to be more consistent (and remove a misleading initial slash). Thanks, daveyjoe.

Backport of r9471 from trunk.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.