Opened 16 years ago
Closed 13 years ago
#9460 closed New feature (fixed)
Template blocks for submit buttons in admin's change view
| Reported by: | kosmik | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Normal | Keywords: | admin, submit, buttons, template |
| Cc: | bernhard.bender@…, Jari Pennanen, andy@…, rvdrijst | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
Having the submit buttons inside their own template blocks in admin/change_form.html would be useful when one wants to customize the buttons. It is of course possible to override the "content" block but that block has quite a lot of code and copying it would be very unefficient. The template block approach seems to be the simplest one. Another option would be to enable overriding the admin/submit_line.html template.
Attachments (3)
Change History (21)
by , 16 years ago
| Attachment: | submit_button_blocks_r9290.diff added |
|---|
follow-up: 2 comment:1 by , 16 years ago
| Cc: | added |
|---|
While you're at it, please inclose the reming section of admin/change_form.html in their own blocks.
I need the submit line block, and would also like to see the remaining parts block'ed.
-Bernhard
comment:2 by , 16 years ago
Which parts in particular would you to have inside their own blocks? I looked at the template but didn't see any places where further blocks would help. Maybe it would be possible for you to create a patch yourself? That's almost easier than trying to explain the required changes to me or someone else.
comment:3 by , 16 years ago
| Cc: | added |
|---|
comment:4 by , 16 years ago
| Cc: | removed |
|---|
comment:6 by , 16 years ago
My patch includes more blocks, I support the idea of having customizable errors too! And, the submit_row_top should be outside the if, if you ask me!
by , 16 years ago
| Attachment: | change_form_all_in_blocks.diff added |
|---|
Even more blocks! Now all is customizable.
comment:7 by , 16 years ago
| Cc: | added |
|---|
comment:8 by , 16 years ago
| Component: | Contrib apps → django.contrib.admin |
|---|---|
| milestone: | → post-1.0 |
| Version: | 1.0 → SVN |
comment:10 by , 16 years ago
| milestone: | → 1.1 |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:11 by , 16 years ago
| Cc: | added |
|---|
comment:12 by , 16 years ago
| Cc: | added |
|---|
comment:13 by , 16 years ago
| milestone: | 1.1 → 1.2 |
|---|
comment:14 by , 15 years ago
| milestone: | 1.2 |
|---|
1.2 is feature-frozen, moving this feature request off the milestone.
comment:15 by , 15 years ago
| Cc: | added; removed |
|---|
comment:16 by , 14 years ago
| Easy pickings: | unset |
|---|---|
| Patch needs improvement: | set |
| Severity: | → Normal |
| Type: | → Uncategorized |
change_form_all_in_blocks.diff fails to apply cleanly on to trunk
comment:17 by , 14 years ago
| Type: | Uncategorized → New feature |
|---|
Adds blocks around the top and bottom submit buttons.